From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f178.google.com (mail-pd0-f178.google.com [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id CBDBD5A96 for ; Fri, 10 Jul 2015 01:04:44 +0200 (CEST) Received: by pdjr16 with SMTP id r16so11530183pdj.3 for ; Thu, 09 Jul 2015 16:04:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=Mq0Fuy8K0jcw8EzaC8i6DpTSeao5iNkw9hsuOHoRZOo=; b=JxSi4QmUlKiCdsR18mHP+AAm4h/NGvHIWcRrBsVHWqp1TKgV6r0LmgJagukvZIUIA7 HwAkjQWT0zbPWH6NbcNA4m+5fE3qrl4d3yZdtUrfMLsMYBiT95FnvEm9/aXinqmA61/v RcsBzqnJi836/mj12yLD3rsANcgNj3CdD7sNNaxQfc3SfIs3CZYhchVvoBWyOjlqqaPT g5nAdRF8jtPMTNrPmDPn1ae2xApv9e8Nt/WfI3sYOhtv+dykwRawmunbMLTJF12S7H3I 4mIi9KMJriHPbMrZyapYjFWejtad2lwL/0awSgE/maQhiJMCDPHIyiuuiSquDYLfo0fS RiVg== X-Gm-Message-State: ALoCoQk5YaA+Jz5j0SUGkz4D/vBShnBGDlTCrSQ0KZ6+ZU3XqEzwhUR05UganuY+m0fO2g1eIDji X-Received: by 10.68.244.73 with SMTP id xe9mr35603076pbc.98.1436483084246; Thu, 09 Jul 2015 16:04:44 -0700 (PDT) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id fu2sm7152941pdb.32.2015.07.09.16.04.43 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Jul 2015 16:04:44 -0700 (PDT) Date: Thu, 9 Jul 2015 16:04:53 -0700 From: Stephen Hemminger To: Thomas Monjalon Message-ID: <20150709160453.7564bd93@urahara> In-Reply-To: <73f62d318c9a4db790b71f334fd9354b@HQ1WP-EXMB11.corp.brocade.com> References: <1436466256-17442-1-git-send-email-stephen@networplumber.org> <73f62d318c9a4db790b71f334fd9354b@HQ1WP-EXMB11.corp.brocade.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH v3 0/8] vmxnet3: driver updates X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2015 23:04:45 -0000 On Thu, 9 Jul 2015 22:32:29 +0000 Thomas Monjalon wrote: > 2015-07-09 18:46, Yong Wang: > > On 7/9/15, 11:24 AM, "dev on behalf of stephen@networkplumber.org" > > wrote: > > >From: Stephen Hemminger > > > > > >These are update to earlier vmxnet3 driver changes. Mostly rebasing > > >to current layout. I skipped the jumbo MTU stuff which works for me > > >but reviewers seem to see problems with. >=20 > It should be possible to discuss with Yong to understand the problem > and submit a separate patch to get it approved. >=20 > > >Stephen Hemminger (8): > > > vmxnet3: enable VLAN filtering > > > vmxnet3: remove mtu check > > > vmxnet3: cleanup txq stats > > > vmxnet3: add support for multi-segment transmit > > > vmxnet3: fix link state handling > > > vmxnet3: support RSS and refactor offload > > > vmxnet3: get rid of DEBUG ifdefs > > > vmxnet3: remove unnecessary inlining > >=20 > > Assuming this series is a simple rebase of the previous patchset, which= I > > already acked (I didn=E2=80=99t see the Acked-by updated though in the = new > > version): >=20 > Yes this series was partially ack'ed and some of them were forgotten in v= 3. >=20 > Stephen, reviewing is not so pleasant and it can be worst when some revie= ws > seem forgotten. Please try to add acks and maintain a changelog across > different versions of a patchset. >=20 > > Series Acked-by: Yong Wang >=20 > Applied, thanks for giving quick ack I work in a Getting-Things-Done fashion and am used to 2 day turn around review time, these cycles are so long that by the time things come back all context is lost.