DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] vfio: fix build if build envrionment is on old kernel
Date: Fri, 10 Jul 2015 10:29:14 -0700	[thread overview]
Message-ID: <20150710102914.3db19e8a@urahara> (raw)
In-Reply-To: <2141795.rDVNFltQvv@xps13>

On Fri, 10 Jul 2015 01:43:17 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> 2015-07-09 16:26, Stephen Hemminger:
> > From: Stephen Hemminger <shemming@brocade.com>
> > 
> > The build of DPDK may be done on a system where Linux headers
> > in /usr/include (and therefore kernel version macro) are much
> > older than the target runtime system.
> 
> It seems strange wanting to build a feature not present in the kernel
> headers. Why not upgrading the build system kernel?

The build machine is running Debian with stock headers and kernel.
I can see many people having build environments controlled by other
parts of organization where you are not allowed to update packages.

> > In order to work around this, one solution is to put in simplified
> > kernel header (this is what the compat stuff is already doing).
> 
> The other solution (as already suggested by Anatoly) is to have a configure
> script (not an autotool one). It would make clear that VFIO support is not
> built.
> Ref: http://dpdk.org/ml/archives/dev/2015-April/016772.html

That won't solve the issue.

The other possiblities are:
 1. Fail the build if VFIO is configured but headers files are missing.
    This is better than surprising user at runtime.
 2. Don't use /usr/include/linux as path as expected path of kernel headers
    instead use build path (this is what modules do).

  reply	other threads:[~2015-07-10 17:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09 23:26 [dpdk-dev] [PATCH v2 0/2] vfio: build cleanups Stephen Hemminger
2015-07-09 23:26 ` [dpdk-dev] [PATCH v2 1/2] vfio: fix build if build envrionment is on old kernel Stephen Hemminger
2015-07-09 23:43   ` Thomas Monjalon
2015-07-10 17:29     ` Stephen Hemminger [this message]
2015-07-10 20:19       ` Thomas Monjalon
2015-07-10 20:44         ` Stephen Hemminger
2015-07-10 21:10           ` Thomas Monjalon
2015-07-10 10:13   ` Burakov, Anatoly
2015-07-10 15:44     ` Stephen Hemminger
2015-07-09 23:26 ` [dpdk-dev] [PATCH v2 2/2] vfio: don't build unnecessary files Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150710102914.3db19e8a@urahara \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=shemming@brocade.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).