DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemming@brocade.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Cc: dev@dpdk.org
Subject: [dpdk-dev] igb PMD should set the default tx wthresh correctly.
Date: Thu, 16 Jul 2015 10:16:50 -0700	[thread overview]
Message-ID: <20150716101650.45c0e25a@urahara> (raw)

Why doesn't igb driver set the wthresh it wants as default?

I see:
	PMD: eth_igb_tx_queue_setup(): To improve 1G driver performance, consider setting the TX WTHRESH value to 4, 8, or 16.

But the default tx_conf has wthresh of 0.

	#define IGB_DEFAULT_TX_WTHRESH      0


Either message should be removed or default TX wthresh should change.

             reply	other threads:[~2015-07-16 17:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 17:16 Stephen Hemminger [this message]
2015-07-17  0:52 ` Lu, Wenzhuo
2015-07-17  2:49   ` Stephen Hemminger
2015-07-17  8:15     ` Thomas Monjalon
2015-07-17 11:06       ` Wiles, Keith
2015-07-20  2:16         ` Lu, Wenzhuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150716101650.45c0e25a@urahara \
    --to=shemming@brocade.com \
    --cc=dev@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).