From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <shemming@Brocade.com>
Received: from mx0a-000f0801.pphosted.com (mx0a-000f0801.pphosted.com
 [67.231.144.122]) by dpdk.org (Postfix) with ESMTP id EDC34376D
 for <dev@dpdk.org>; Thu, 16 Jul 2015 19:16:51 +0200 (CEST)
Received: from pps.filterd (m0000542.ppops.net [127.0.0.1])
 by mx0a-000f0801.pphosted.com (8.15.0.59/8.15.0.59) with SMTP id
 t6GGWaPS022346; Thu, 16 Jul 2015 10:16:50 -0700
Received: from brmwp-exchub02.corp.brocade.com ([208.47.132.227])
 by mx0a-000f0801.pphosted.com with ESMTP id 1vp7vr16cj-1
 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT);
 Thu, 16 Jul 2015 10:16:50 -0700
Received: from BRMWP-EXMB11.corp.brocade.com (172.16.59.77) by
 BRMWP-EXCHUB02.corp.brocade.com (172.16.187.99) with Microsoft SMTP Server
 (TLS) id 14.3.123.3; Thu, 16 Jul 2015 11:16:48 -0600
Received: from urahara (10.252.48.10) by BRMWP-EXMB11.corp.brocade.com
 (172.16.59.77) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Thu, 16 Jul
 2015 11:16:47 -0600
Date: Thu, 16 Jul 2015 10:16:50 -0700
From: Stephen Hemminger <shemming@brocade.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Message-ID: <20150716101650.45c0e25a@urahara>
Organization: Brocade
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: hq1wp-excas12.corp.brocade.com (10.70.38.22) To
 BRMWP-EXMB11.corp.brocade.com (172.16.59.77)
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151, 1.0.33,
 0.0.0000
 definitions=2015-07-16_05:2015-07-16,2015-07-16,1970-01-01 signatures=0
X-Proofpoint-Spam-Details: rule=probablespam policy=default score=91
 spamscore=91 suspectscore=1
 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=7.0.1-1506180000 definitions=main-1507160242
Cc: dev@dpdk.org
Subject: [dpdk-dev] igb PMD should set the default tx wthresh correctly.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jul 2015 17:16:52 -0000

Why doesn't igb driver set the wthresh it wants as default?

I see:
	PMD: eth_igb_tx_queue_setup(): To improve 1G driver performance, consider setting the TX WTHRESH value to 4, 8, or 16.

But the default tx_conf has wthresh of 0.

	#define IGB_DEFAULT_TX_WTHRESH      0


Either message should be removed or default TX wthresh should change.