Re: [dpdk-dev] Does FreeBSD's nic_uio have bind/unbind interface support?

Re: [dpdk-dev] Does FreeBSD's nic_uio have bind/unbind interface support?

[David Marchand]

Hello Rahul,

(cc Bruce)

How about removing this "whitelist" from the nic_uio driver and just rely
on the hw.nic_uio.bdfs parameter to find out which devices to bind ?


-- 
David Marchand

On Thu, Jul 16, 2015 at 2:12 PM, Rahul Lakkireddy <
rahul.lakkireddy@chelsio.com> wrote:

> Hi All,
>
> It seems that on FreeBSD, nic_uio currently only binds the devices matched
> in
> rte_pci_dev_ids.h.  On Linux, it's possible to bind any listed device with
> igb_uio or vfio.
>
> The pci device ids supported by cxgbe PMD, maintained in a table, are not
> part
> of rte_pci_dev_ids.h.  Hence, Chelsio T5 cards don't get bound to nic_uio,
> resulting in probe failure on FreeBSD.
>
> On manually adding Chelsio pci device id to rte_pci_dev_ids.h, the Chelsio
> T5
> card gets detected fine on FreeBSD.
>
> So, we would like to know and understand if adding all supported Chelsio
> pci
> device ids to rte_pci_dev_ids.h is the correct way of doing things for
> FreeBSD?
>
> Any suggestions are appreciated.
>
> Thanks,
> Rahul
>

Re: [dpdk-dev] Does FreeBSD's nic_uio have bind/unbind interface support?

[Bruce Richardson]

On Thu, Jul 16, 2015 at 09:57:03AM +0200, David Marchand wrote:
> Hello Rahul,
> 
> (cc Bruce)
> 
> How about removing this "whitelist" from the nic_uio driver and just rely
> on the hw.nic_uio.bdfs parameter to find out which devices to bind ?
>
Yes, that would be my thinking too. It probably should work that way, much as
linux does.

/Bruce

> 
> -- 
> David Marchand
> 
> On Thu, Jul 16, 2015 at 2:12 PM, Rahul Lakkireddy <
> rahul.lakkireddy@chelsio.com> wrote:
> 
> > Hi All,
> >
> > It seems that on FreeBSD, nic_uio currently only binds the devices matched
> > in
> > rte_pci_dev_ids.h.  On Linux, it's possible to bind any listed device with
> > igb_uio or vfio.
> >
> > The pci device ids supported by cxgbe PMD, maintained in a table, are not
> > part
> > of rte_pci_dev_ids.h.  Hence, Chelsio T5 cards don't get bound to nic_uio,
> > resulting in probe failure on FreeBSD.
> >
> > On manually adding Chelsio pci device id to rte_pci_dev_ids.h, the Chelsio
> > T5
> > card gets detected fine on FreeBSD.
> >
> > So, we would like to know and understand if adding all supported Chelsio
> > pci
> > device ids to rte_pci_dev_ids.h is the correct way of doing things for
> > FreeBSD?
> >
> > Any suggestions are appreciated.
> >
> > Thanks,
> > Rahul
> >

Re: [dpdk-dev] Does FreeBSD's nic_uio have bind/unbind interface support?

[Rahul Lakkireddy]

Hi Bruce and David,

On Thu, Jul 16, 2015 at 09:57:15 +0100, Bruce Richardson wrote:
> On Thu, Jul 16, 2015 at 09:57:03AM +0200, David Marchand wrote:
> > Hello Rahul,
> > 
> > (cc Bruce)
> > 
> > How about removing this "whitelist" from the nic_uio driver and just rely
> > on the hw.nic_uio.bdfs parameter to find out which devices to bind ?
> >
> Yes, that would be my thinking too. It probably should work that way, much as
> linux does.
> 
> /Bruce
> 

Tried the suggestion on removing the "whitelist" checks and it seems to work
fine for us.  It's allowing T5 devices to be bound to nic_uio and also results
in successful probe.

Will prepare a patch to remove the whitelist checks and pci id entries from
nic_uio and post soon.

Thanks,
Rahul

[dpdk-dev] Does FreeBSD's nic_uio have bind/unbind interface support?

[Rahul Lakkireddy]

Hi All,

It seems that on FreeBSD, nic_uio currently only binds the devices matched in
rte_pci_dev_ids.h.  On Linux, it's possible to bind any listed device with
igb_uio or vfio.

The pci device ids supported by cxgbe PMD, maintained in a table, are not part
of rte_pci_dev_ids.h.  Hence, Chelsio T5 cards don't get bound to nic_uio,
resulting in probe failure on FreeBSD.

On manually adding Chelsio pci device id to rte_pci_dev_ids.h, the Chelsio T5
card gets detected fine on FreeBSD.

So, we would like to know and understand if adding all supported Chelsio pci
device ids to rte_pci_dev_ids.h is the correct way of doing things for FreeBSD?

Any suggestions are appreciated.

Thanks,
Rahul