From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-000f0801.pphosted.com (mx0a-000f0801.pphosted.com [67.231.144.122]) by dpdk.org (Postfix) with ESMTP id 4D0485A59 for ; Fri, 17 Jul 2015 04:49:21 +0200 (CEST) Received: from pps.filterd (m0048193.ppops.net [127.0.0.1]) by mx0a-000f0801.pphosted.com (8.15.0.59/8.15.0.59) with SMTP id t6H2mg7Z007866; Thu, 16 Jul 2015 19:49:20 -0700 Received: from hq1wp-exchub01.corp.brocade.com ([144.49.131.13]) by mx0a-000f0801.pphosted.com with ESMTP id 1vpqt1048q-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Thu, 16 Jul 2015 19:49:19 -0700 Received: from HQ1WP-EXMB12.corp.brocade.com (10.70.20.186) by HQ1WP-EXCHUB01.corp.brocade.com (10.70.36.99) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 16 Jul 2015 19:49:19 -0700 Received: from urahara (10.252.52.2) by HQ1WP-EXMB12.corp.brocade.com (10.70.20.186) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Thu, 16 Jul 2015 19:49:17 -0700 Date: Thu, 16 Jul 2015 19:49:20 -0700 From: Stephen Hemminger To: "Lu, Wenzhuo" Message-ID: <20150716194920.3710f25e@urahara> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909CFAAE6@shsmsx102.ccr.corp.intel.com> References: <20150716101650.45c0e25a@urahara> <6A0DE07E22DDAD4C9103DF62FEBC0909CFAAE6@shsmsx102.ccr.corp.intel.com> Organization: Brocade MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.252.52.2] X-ClientProxiedBy: hq1wp-excas12.corp.brocade.com (10.70.38.22) To HQ1WP-EXMB12.corp.brocade.com (10.70.20.186) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151, 1.0.33, 0.0.0000 definitions=2015-07-17_01:2015-07-17,2015-07-16,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=4 spamscore=4 suspectscore=1 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1506180000 definitions=main-1507170023 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] igb PMD should set the default tx wthresh correctly. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2015 02:49:21 -0000 On Fri, 17 Jul 2015 00:52:09 +0000 "Lu, Wenzhuo" wrote: > Hi Stephen, > I don't think there's a conflict. The message just reminder us that we can adjust the values to achieve better performance. > I saw ixgbe and i40e also use 0 as the same default value. To my opinion, it's good to keep the same behavior. > Thanks. In my opnion, no application should have to make special case setup for each device type. Having to have a table that lists all the parameters for each device name is not supportable or scaleable. The DPDK started out as "lets do benchmarks fast" but as a production toolkit it needs to stop having this kind of thing. The message shows up to the end-user, who thinks it is a driver bug. The "us" is now real customers not DPDK developers.