From: Neil Horman <nhorman@tuxdriver.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code
Date: Fri, 17 Jul 2015 08:25:48 -0400 [thread overview]
Message-ID: <20150717122548.GA3931@neilslaptop.think-freely.org> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2F6F572@IRSMSX103.ger.corp.intel.com>
On Fri, Jul 17, 2015 at 11:45:10AM +0000, Mcnamara, John wrote:
> > -----Original Message-----
> > From: Neil Horman [mailto:nhorman@tuxdriver.com]
> > Sent: Monday, July 13, 2015 3:00 PM
> > To: Mcnamara, John
> > Cc: dev@dpdk.org; vladz@cloudius-systems.com
> > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code
> >
> > > > > - dev_started : 1; /**< Device state: STARTED(1) / STOPPED(0). */
> > > > > + dev_started : 1, /**< Device state: STARTED(1) / STOPPED(0). */
> > > > > + lro : 1; /**< RX LRO is ON(1) / OFF(0) */
> > > > >
> > > > >
> > >
> > Thank you, I'll ack as soon as Chao confirms its not a problem on ppc Neil
>
> Hi,
>
> Just pinging Chao Zhu on this again so that it isn't forgotten.
>
> Neil, just to be clear, are you looking for a validate-abi.sh check on PPC?
>
Yes, correct.
> Just for context, the lro flag doesn't seem to be used anywhere that would be affected by endianness:
>
> $ ag -w "\->lro"
> drivers/net/ixgbe/ixgbe_rxtx.c
> 3767: if (dev->data->lro) {
> 3967: dev->data->lro = 1;
>
> drivers/net/ixgbe/ixgbe_ethdev.c
> 1689: dev->data->lro = 0;
>
But this data is visible to the outside application, correct? If so then we
can't rely on internal-only usage as a guide. If it is only internally visible,
then yes, you are correct, endianess is not an issue then
neil
> John.
> --
>
>
next prev parent reply other threads:[~2015-07-17 12:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 10:26 John McNamara
2015-07-13 10:42 ` Neil Horman
2015-07-13 10:46 ` Thomas Monjalon
2015-07-13 10:47 ` Mcnamara, John
2015-07-13 13:59 ` Neil Horman
2015-07-17 11:45 ` Mcnamara, John
2015-07-17 12:25 ` Neil Horman [this message]
2015-07-31 9:03 ` Mcnamara, John
2015-07-31 10:34 ` Neil Horman
2015-08-03 2:39 ` Chao Zhu
2015-08-03 3:45 ` Chao Zhu
2015-08-03 8:41 ` Thomas Monjalon
2015-08-03 12:53 ` Neil Horman
2015-07-16 22:22 ` Vlad Zolotarov
2015-08-02 21:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717122548.GA3931@neilslaptop.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).