From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C2AA4255 for ; Wed, 22 Jul 2015 11:59:49 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 22 Jul 2015 02:59:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,522,1432623600"; d="scan'208";a="733312111" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.62]) by orsmga001.jf.intel.com with SMTP; 22 Jul 2015 02:59:47 -0700 Received: by (sSMTP sendmail emulation); Wed, 22 Jul 2015 10:59:46 +0025 Date: Wed, 22 Jul 2015 10:59:46 +0100 From: Bruce Richardson To: Zoltan Kiss Message-ID: <20150722095946.GB11652@bricha3-MOBL3> References: <1437492307-29754-1-git-send-email-bruce.richardson@intel.com> <1437556410-14102-1-git-send-email-bruce.richardson@intel.com> <55AF66B6.1000305@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55AF66B6.1000305@linaro.org> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix check for split packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2015 09:59:51 -0000 On Wed, Jul 22, 2015 at 10:47:34AM +0100, Zoltan Kiss wrote: > Hi, > > And what happens if someone changes RTE_IXGBE_VPMD_RX_BURST to something > else than 32? I guess this bug were introduced when someone raised it from > 16 to 32 Actually, no, this bug is purely due to me getting my maths wrong when I wrote this function. The vector PMD has always worked in bursts of 32 at a time. > I think you are better off with a for loop which uses this value. Or at > least make a comment around RTE_IXGBE_VPMD_RX_BURST that if you change that > value this check should be modified as well. The vector PMD always works off a fixed 32 burst size. Any change to that will lead to many changes in the code, so I don't believe a loop is necessary. Regards, /Bruce > > Regards, > > Zoltan > > On 22/07/15 10:13, Bruce Richardson wrote: > >The check for split packets to be reassembled in the vector ixgbe PMD > >was incorrectly only checking the first 16 elements of the array instead > >of all 32. This is fixed by changing the uint32_t values to be uint64_t > >instead. > > > >Fixes: cf4b4708a88a ("ixgbe: improve slow-path perf with vector scattered Rx") > > > >Reported-by: Zoltan Kiss > >Signed-off-by: Bruce Richardson > > > >--- > >V2: Rename variable from split_fl32 to split_fl64 to match type change. > >--- > > drivers/net/ixgbe/ixgbe_rxtx_vec.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > >diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec.c b/drivers/net/ixgbe/ixgbe_rxtx_vec.c > >index d3ac74a..f2052c6 100644 > >--- a/drivers/net/ixgbe/ixgbe_rxtx_vec.c > >+++ b/drivers/net/ixgbe/ixgbe_rxtx_vec.c > >@@ -549,10 +549,10 @@ ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, > > return 0; > > > > /* happy day case, full burst + no packets to be joined */ > >- const uint32_t *split_fl32 = (uint32_t *)split_flags; > >+ const uint64_t *split_fl64 = (uint64_t *)split_flags; > > if (rxq->pkt_first_seg == NULL && > >- split_fl32[0] == 0 && split_fl32[1] == 0 && > >- split_fl32[2] == 0 && split_fl32[3] == 0) > >+ split_fl64[0] == 0 && split_fl64[1] == 0 && > >+ split_fl64[2] == 0 && split_fl64[3] == 0) > > return nb_bufs; > > > > /* reassemble any packets that need reassembly*/ > >