Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code

[Neil Horman <nhorman@tuxdriver.com>]

On Fri, Jul 31, 2015 at 09:03:45AM +0000, Mcnamara, John wrote:
> > -----Original Message-----
> > From: Neil Horman [mailto:nhorman@tuxdriver.com]
> > Sent: Monday, July 13, 2015 3:00 PM
> > To: Mcnamara, John
> > Cc: dev@dpdk.org; vladz@cloudius-systems.com
> > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code
> > 
> > On Mon, Jul 13, 2015 at 10:47:03AM +0000, Mcnamara, John wrote:
> > > > -----Original Message-----
> > > > From: Neil Horman [mailto:nhorman@tuxdriver.com]
> > > > Sent: Monday, July 13, 2015 11:42 AM
> > > > To: Mcnamara, John
> > > > Cc: dev@dpdk.org; vladz@cloudius-systems.com
> > > > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code
> > > >
> > > > On Mon, Jul 13, 2015 at 11:26:25AM +0100, John McNamara wrote:
> > > > > Fix for ABI breakage introduced in LRO addition. Moves lro
> > > > > bitfield to the end of the struct/member.
> > > > >
> > > > > Fixes: 8eecb3295aed (ixgbe: add LRO support)
> > > > >
> > > > > Signed-off-by: John McNamara <john.mcnamara@intel.com>
> > > > > ---
> > > > >  lib/librte_ether/rte_ethdev.h | 4 ++--
> > > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git a/lib/librte_ether/rte_ethdev.h
> > > > > b/lib/librte_ether/rte_ethdev.h index 79bde89..1c3ace1 100644
> > > > > --- a/lib/librte_ether/rte_ethdev.h
> > > > > +++ b/lib/librte_ether/rte_ethdev.h
> > > > > @@ -1578,9 +1578,9 @@ struct rte_eth_dev_data {
> > > > >  	uint8_t port_id;           /**< Device [external] port
> > identifier.
> > > > */
> > > > >  	uint8_t promiscuous   : 1, /**< RX promiscuous mode ON(1) /
> > OFF(0).
> > > > */
> > > > >  		scattered_rx : 1,  /**< RX of scattered packets is ON(1)
> > /
> > > > OFF(0) */
> > > > > -		lro          : 1,  /**< RX LRO is ON(1) / OFF(0) */
> > > > >  		all_multicast : 1, /**< RX all multicast mode ON(1) /
> > OFF(0).
> > > > */
> > > > > -		dev_started : 1;   /**< Device state: STARTED(1) /
> > STOPPED(0).
> > > > */
> > > > > +		dev_started : 1,   /**< Device state: STARTED(1) /
> > STOPPED(0).
> > > > */
> > > > > +		lro         : 1;   /**< RX LRO is ON(1) / OFF(0) */
> > > > >  };
> > > > >
> > > > >  /**
> > > > > --
> > > > > 1.8.1.4
> > > > >
> > > > >
> > > > I presume the ABI checker stopped complaining about this with the
> > > > patch, yes?
> > >
> > > Hi Neil,
> > >
> > > Yes, I replied about that in the previous thread.
> > >
> > Thank you, I'll ack as soon as Chao confirms its not a problem on ppc Neil
> 
> Hi Chao,
> 
> Any reply on this.
> 
> Neil, if there is no reply to this from the PPC maintainer do you have any objection to this going in as is. 
> 
> It at least fixes the LRO ABI breakage on the platforms we can test on.
> 
> John
> 
Well, I suppose at this point the only thing its hurting is ppc, so no, no
objections.  But its pretty disheartening for an arch maintainer to dissappear
so soon after adding arch support.

Neil