From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.mhcomputing.net (master.mhcomputing.net [74.208.46.186]) by dpdk.org (Postfix) with ESMTP id DEBEF5A79 for ; Sat, 1 Aug 2015 05:57:10 +0200 (CEST) Received: by mail.mhcomputing.net (Postfix, from userid 1000) id C411F80C502; Fri, 31 Jul 2015 20:56:55 -0700 (PDT) Date: Fri, 31 Jul 2015 20:56:55 -0700 From: Matthew Hall To: Cunming Liang Message-ID: <20150801035655.GA29805@mhcomputing.net> References: <1438306572-25434-1-git-send-email-cunming.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438306572-25434-1-git-send-email-cunming.liang@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix negative value for undetermined numa_node X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Aug 2015 03:57:11 -0000 I asked about this many months ago and was informed that "-1" is a "standard error value" that I should expect from these APIs when NUMA is not present. Now we're saying I have to change my code again to handle a zero value? Also not sure how to tell the difference between no NUMA, something running on socket zero, and something with multiple sockets. Seems like we need a bit of thought about how the NUMA APIs should behave overall. Matthew. On Fri, Jul 31, 2015 at 09:36:12AM +0800, Cunming Liang wrote: > The patch sets zero as the default value of pci device numa_node > if the socket could not be determined. > It provides the same default value as FreeBSD which has no NUMA support, > and makes the return value of rte_eth_dev_socket_id() be consistent > with the API description. > > Signed-off-by: Cunming Liang