From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 50A505927 for ; Fri, 28 Aug 2015 12:32:58 +0200 (CEST) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1ZVGxn-0003SD-Gk; Fri, 28 Aug 2015 06:32:56 -0400 Date: Fri, 28 Aug 2015 06:32:45 -0400 From: Neil Horman To: "Iremonger, Bernard" Message-ID: <20150828103245.GB3351@hmsreliant.think-freely.org> References: <1440690041-32391-1-git-send-email-bernard.iremonger@intel.com> <20150827174357.GC8113@tuxdriver.com> <8CEF83825BEC744B83065625E567D7C219F4883E@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8CEF83825BEC744B83065625E567D7C219F4883E@IRSMSX108.ger.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -1.0 (-) X-Spam-Status: No Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [RFC PATCH 0/6] remove pci driver from vdevs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2015 10:32:58 -0000 On Fri, Aug 28, 2015 at 08:15:47AM +0000, Iremonger, Bernard wrote: > Hi John, > > > -----Original Message----- > > From: John W. Linville [mailto:linville@tuxdriver.com] > > Sent: Thursday, August 27, 2015 6:44 PM > > To: Iremonger, Bernard > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [RFC PATCH 0/6] remove pci driver from vdevs > > > > On Thu, Aug 27, 2015 at 04:40:35PM +0100, Bernard Iremonger wrote: > > > There is a dummy pci driver in the vdev PMD's at present. > > > This RFC proposes to remove the pci driver from the vdev PMD's. > > > Changes have been made to librte_ether to handle vdevs which do not > > have a pci driver. > > > > > > The pdev PMD's should work as before with the changes to librte_ether > > > The vdev PMD's which still have a pci driver should work as before with the > > librte_ether changes. > > > > > > The following vdev PMD's have had the pci driver removed > > > > > > bonding PMD > > > null PMD > > > pcap PMD > > > ring PMD > > > > Any reason there is no patch for the af_packet driver? > > > > John > > I have just modified the Intel vdev PMD's. > It would be best if the owners of the non Intel vdev's submitted patches for their drivers. > I disagree. Its ok given that this is an RFC patch I suppose, but if you intend to actually propose this change for review, you need to modify all affected drivers in a single commit. Asking individual driver maintainers to submit patches to not access a struct element that is removed in a separate patch will by definition cause FTBFS errors. All references to the structure member being removed must also be eliminated in the same or a prior commit, preferably the former. Neil > Regards, > > Bernard. > > > >