From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 2D8A6379E
 for <dev@dpdk.org>; Thu, 10 Sep 2015 21:33:03 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga103.jf.intel.com with ESMTP; 10 Sep 2015 12:33:03 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,506,1437462000"; d="scan'208";a="642461075"
Received: from irvmail001.ir.intel.com ([163.33.26.43])
 by orsmga003.jf.intel.com with ESMTP; 10 Sep 2015 12:33:02 -0700
Received: from sivlogin002.ir.intel.com (sivlogin002.ir.intel.com
 [10.237.217.37])
 by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id
 t8AJX1jW030514; Thu, 10 Sep 2015 20:33:01 +0100
Received: from sivlogin002.ir.intel.com (localhost [127.0.0.1])
 by sivlogin002.ir.intel.com with ESMTP id t8AJX1Jt001210;
 Thu, 10 Sep 2015 20:33:01 +0100
Received: (from fyigit@localhost)
	by sivlogin002.ir.intel.com with œ id t8AJX0Yu001206;
	Thu, 10 Sep 2015 20:33:00 +0100
X-Authentication-Warning: sivlogin002.ir.intel.com: fyigit set sender to
 ferruh.yigit@intel.com using -f
Date: Thu, 10 Sep 2015 20:33:00 +0100
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: David Marchand <david.marchand@6wind.com>, dev@dpdk.org
Message-ID: <20150910193300.GA32153@sivlogin002.ir.intel.com>
References: <1441900908-29763-1-git-send-email-ferruh.yigit@intel.com>
 <CALwxeUuh3JWTxRbw5sRmrgn4neaEqNdh8OW6Ppkdet3Kcohe4g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALwxeUuh3JWTxRbw5sRmrgn4neaEqNdh8OW6Ppkdet3Kcohe4g@mail.gmail.com>
User-Agent: Mutt/1.4.2.3i
Subject: Re: [dpdk-dev] [PATCH] igb_uio: use existing PCI macros
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Sep 2015 19:33:04 -0000

Hi David,
> Hello Ferruh,
> 
> On Thu, Sep 10, 2015 at 6:01 PM, Ferruh Yigit <ferruh.yigit@intel.com>
> wrote:
> 
> > To get pci_dev and vf number from dev, benefit from
> > existing macros in pci.h
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> 
> Correct me if I am wrong but you might need to provide wrappers for kernel
> version <= 2.6.34 (or something that indicates availability of those).

Correct, those macros available after kernel version >= 2.6.34.
If these is any chance that one using older kernel than this version,
instead of having wrappers I am for keeping existing implementation and
drop this patch.

> 
> Please, can you confirm this is just a cleanup and you are not fixing
> anything ?

Just cleanup.

Thanks,
ferruh