DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] rte_sched: whitespace cleanup
Date: Fri, 11 Sep 2015 12:18:58 -0700	[thread overview]
Message-ID: <20150911121858.00357602@urahara> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126478BAA4A@IRSMSX108.ger.corp.intel.com>

On Fri, 11 Sep 2015 17:31:10 +0000
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com> wrote:

> >   *   p00  _______   p10  _______   p20  _______   p30  _______
> > - * ----->|       |----->|       |----->|       |----->|       |----->
> > + *----->|       |----->|       |----->|       |----->|       |----->
> >   *       |   0   |      |   1   |      |   2   |      |   3   |
> > - * ----->|_______|----->|_______|----->|_______|----->|_______|----->
> > + *----->|_______|----->|_______|----->|_______|----->|_______|----->
> >   *   p01            p11            p21            p31
> >   *
> >   ***/  
> 
> You are breaking the ASCII diagram above by removing the first space on the line, but not for all lines. Please check that diagram is OK after the space removal.

Sorry, it was global repace issue.

  reply	other threads:[~2015-09-11 19:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-28 16:49 [dpdk-dev] [PATCH 0/2] rte_sched: cleanups Stephen Hemminger
2015-08-28 16:49 ` [dpdk-dev] [PATCH 1/2] rte_sched: whitespace cleanup Stephen Hemminger
2015-09-11 17:31   ` Dumitrescu, Cristian
2015-09-11 19:18     ` Stephen Hemminger [this message]
2015-08-28 16:49 ` [dpdk-dev] [PATCH 2/2] rte_sched: remove useless bitmap_free Stephen Hemminger
2015-09-11 17:28   ` Dumitrescu, Cristian
2015-09-11 19:18     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150911121858.00357602@urahara \
    --to=stephen@networkplumber.org \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).