From: Stephen Hemminger <stephen@networkplumber.org>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add new RX/TX queue state arrays in rte_eth_dev_data
Date: Mon, 21 Sep 2015 15:40:24 -0700 [thread overview]
Message-ID: <20150921154024.3890eb76@urahara> (raw)
In-Reply-To: <1442440284-6175-1-git-send-email-pablo.de.lara.guarch@intel.com>
On Wed, 16 Sep 2015 22:51:24 +0100
Pablo de Lara <pablo.de.lara.guarch@intel.com> wrote:
> This is important to avoid trying to start/stop twice a queue,
> which will result in undefined behaviour
> (which may cause RX/TX disruption).
>
> Mind that only the PMDs which have queue_start/stop functions
> have been changed to update this field, as the functions will
> check the queue state before switching it.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
I agree that the DPDK API should check for buggy manipulation
in the control path. But this should be done in generic code.
Anything where you have to change any driver is making more work
than necessary.
next prev parent reply other threads:[~2015-09-21 22:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 21:51 Pablo de Lara
2015-09-21 22:40 ` Stephen Hemminger [this message]
2015-09-23 6:56 ` Qiu, Michael
2015-09-23 7:39 ` De Lara Guarch, Pablo
2015-09-23 8:22 ` Ananyev, Konstantin
2015-09-23 11:49 ` Ananyev, Konstantin
2015-11-04 16:53 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921154024.3890eb76@urahara \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).