From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 3B9A98D89 for ; Tue, 22 Sep 2015 00:40:12 +0200 (CEST) Received: by pacex6 with SMTP id ex6so128700192pac.0 for ; Mon, 21 Sep 2015 15:40:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=40w2wbkKe6hSy0GYKuGwbEtAkUlOA3Fvw+RdN+P4GxI=; b=MNBC9Av5gywwxYhs1FYuyLQDk+6b90zVXJn+UY38LhGk2ZtgF65HgPxCWc40B50GpD Qvw8+imh5INxZNNiSwFEldJ0pAlEKXia9DwGFE5v8NP8PviLd9T+G3sLNmVubsW9HK0B 62qUr8k/AaHQlNwUVBNLFagMbRJ0UKqI6h2hlE7YJMr1xv3RoxUvgZ/EooNf5Db2KBb8 nEUtlMlUoTerCLYX+9ClwHJZXIqrgjokUteizLY6FvpFY76acY3UOR2QlqyN/3Lf6Yxl /C0ph0PBzgmcPr361OkcriGzlXzqJAZBrdibyUROlR6GEeOpy3ruHk5slO6a1VAAKa2I SSTw== X-Gm-Message-State: ALoCoQn172SBgn9uU9JXnqakzg9mx+D+1n80EMjcYfkDaFoULpeUlnzqM9z30IgJ0KyjQUNlYN/4 X-Received: by 10.66.253.229 with SMTP id ad5mr27685928pad.101.1442875211536; Mon, 21 Sep 2015 15:40:11 -0700 (PDT) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id qr5sm26494766pbb.26.2015.09.21.15.40.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Sep 2015 15:40:11 -0700 (PDT) Date: Mon, 21 Sep 2015 15:40:24 -0700 From: Stephen Hemminger To: Pablo de Lara Message-ID: <20150921154024.3890eb76@urahara> In-Reply-To: <1442440284-6175-1-git-send-email-pablo.de.lara.guarch@intel.com> References: <1442440284-6175-1-git-send-email-pablo.de.lara.guarch@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add new RX/TX queue state arrays in rte_eth_dev_data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Sep 2015 22:40:12 -0000 On Wed, 16 Sep 2015 22:51:24 +0100 Pablo de Lara wrote: > This is important to avoid trying to start/stop twice a queue, > which will result in undefined behaviour > (which may cause RX/TX disruption). > > Mind that only the PMDs which have queue_start/stop functions > have been changed to update this field, as the functions will > check the queue state before switching it. > > Signed-off-by: Pablo de Lara I agree that the DPDK API should check for buggy manipulation in the control path. But this should be done in generic code. Anything where you have to change any driver is making more work than necessary.