From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com
[209.85.220.44]) by dpdk.org (Postfix) with ESMTP id C281E8DB0
for <dev@dpdk.org>; Tue, 22 Sep 2015 18:34:24 +0200 (CEST)
Received: by padhy16 with SMTP id hy16so13729421pad.1
for <dev@dpdk.org>; Tue, 22 Sep 2015 09:34:23 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-type:content-transfer-encoding;
bh=UWSizQvAp/eUxGJltcu8dds8IK6vQ059APiA1dkeNOI=;
b=IL985INqT/0r1YQKjzDofNezUhBSQOm12t+F9EIi/Eunbi4nMhfhNEOAdASkUPq1Sb
rOBkZVD2zkUwY4lA6rKm+Y26poRA4r34Lv0JaEDZudtWrYp/4OldO7zzAJanDmtBoyA3
fA8i4WYTPThu5eJMcCTkTlwW7NzhQhR57pbz4/a76YTgl95G3+VAYNwFhVgm/ZtCQ+QH
jZgCZZKyxoy0hYMpUo28Pw0HvZWhzgAEoESFgovypf4211x2ER23pqKd1Xnw4TVzFRrZ
5js4HPrdXvv4x1Z9t0RV2Rp0cE0GBhPmNENtJCZQDXoRJKjIJwdXAFMX0uj5seDL8Wd6
CKoA==
X-Gm-Message-State: ALoCoQlV6RRu1tNISSlOf1NVjc0GqznEf23+7R0cYJEKeihgO8ew6PPJic7J9ncntxje2d+cxofX
X-Received: by 10.68.100.36 with SMTP id ev4mr31691847pbb.119.1442939662974;
Tue, 22 Sep 2015 09:34:22 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
[50.53.82.155])
by smtp.gmail.com with ESMTPSA id jv5sm3207070pbc.47.2015.09.22.09.34.22
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Tue, 22 Sep 2015 09:34:22 -0700 (PDT)
Date: Tue, 22 Sep 2015 09:34:34 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20150922093434.4f98e10b@urahara>
In-Reply-To: <3616846.ZsjBrqIcvx@xps13>
References: <1442322395-23365-1-git-send-email-piotrx.t.azarewicz@intel.com>
<20150921153530.0b198652@urahara>
<3EB4FA525960D640B5BDFFD6A3D89126478D65D5@IRSMSX108.ger.corp.intel.com>
<3616846.ZsjBrqIcvx@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1 1/3] port: add mp/mc ring ports
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Sep 2015 16:34:25 -0000
On Tue, 22 Sep 2015 16:23:51 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 2015-09-22 11:34, Dumitrescu, Cristian:
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen
> > > Hemminger
> > > Sent: Tuesday, September 22, 2015 1:36 AM
> > > To: Azarewicz, PiotrX T
> > > Cc: dev@dpdk.org
> > > Subject: Re: [dpdk-dev] [PATCH v1 1/3] port: add mp/mc ring ports
> > >
> > > On Tue, 15 Sep 2015 15:06:33 +0200
> > > Piotr Azarewicz <piotrx.t.azarewicz@intel.com> wrote:
> > >
> > > > +static inline void
> > > > +send_burst_mp(struct rte_port_ring_writer *p)
> > > > +{
> > >
> > > compiler will inline static functions anyway. No need to add inline qualifier
> >
> > Hi Stephen,
> >
> > Using 'static inline' seems to be the standard practice in DPDK and a good practice as well.
>
> Why do you think it is a good practice?
> Forced inlining can be a random optimization having negative effects.
Agreed. Modern compilers make good decisions.