From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] hash: rename unused field to "reserved"
Date: Tue, 22 Sep 2015 16:01:57 -0700 [thread overview]
Message-ID: <20150922160157.1f22942c@urahara> (raw)
In-Reply-To: <1436805525-25916-1-git-send-email-bruce.richardson@intel.com>
On Mon, 13 Jul 2015 17:38:45 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:
> The cuckoo hash has a fixed number of entries per bucket, so the
> configuration parameter for this is unused. We change this field in the
> parameters struct to "reserved" to indicate that there is now no such
> parameter value, while at the same time keeping ABI consistency.
>
> Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation")
>
> Suggested-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
I am sorry this patch went into 2.1 because it broke source code
compatibility. To me having source code recompile compatibility is MORE
important than ABI compatibility.
prev parent reply other threads:[~2015-09-22 23:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 16:25 [dpdk-dev] [PATCH] " Bruce Richardson
2015-07-13 16:28 ` Bruce Richardson
2015-07-13 16:38 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2015-07-13 17:29 ` Thomas Monjalon
2015-07-15 8:08 ` Olga Shern
2015-07-15 8:19 ` De Lara Guarch, Pablo
2015-09-22 23:01 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922160157.1f22942c@urahara \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).