From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com
 [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id A262456B7
 for <dev@dpdk.org>; Wed, 23 Sep 2015 01:01:46 +0200 (CEST)
Received: by pacbt3 with SMTP id bt3so3526986pac.3
 for <dev@dpdk.org>; Tue, 22 Sep 2015 16:01:46 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=UM4VGGjk5mnRRKtJI3XVQ1SfrEmOAkmcTBx1gL6Hhew=;
 b=C08SIPBm4CrY4mHTclHkEkMlj4lvhuAt6yUJo/YwMYK40o/bjnrRJdhEqIUKQfZi2X
 qGsbYfGZF1clZp6RAMXdCmYP73+ikz854ZUpt3dRKsnbiSuYUhMdse2xnd9uiZ5zQ6IC
 4TKgrk2MUgZ+7ZX9BGN2JO98beV4U65q9VqE5ji/APcs3VoH0qo67FyyngEu6QwHFdjC
 HvEXO2eUqY5pyrysrCKwOOdApOtsp0MG2SUTPXOL/qepgrFfJauhAWho7fqYQLLVjtl0
 Fe0X81vK63+QL821M23Z8f8orvrfi4BWjta3KCIl0f83oMEnMQc1q5UOiWgdA9CLBlOc
 28LA==
X-Gm-Message-State: ALoCoQmYXRO8gXd4XpyP3BfevVXuVRDnvuIaXRPgWkazeAwK6RGIy7mbAqDRRy+0WYWJ/OXUrmCJ
X-Received: by 10.66.175.7 with SMTP id bw7mr34581129pac.155.1442962905959;
 Tue, 22 Sep 2015 16:01:45 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id eh4sm4246659pbd.27.2015.09.22.16.01.45
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 22 Sep 2015 16:01:45 -0700 (PDT)
Date: Tue, 22 Sep 2015 16:01:57 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Message-ID: <20150922160157.1f22942c@urahara>
In-Reply-To: <1436805525-25916-1-git-send-email-bruce.richardson@intel.com>
References: <1436804751-23156-1-git-send-email-bruce.richardson@intel.com>
 <1436805525-25916-1-git-send-email-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] hash: rename unused field to "reserved"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Sep 2015 23:01:46 -0000

On Mon, 13 Jul 2015 17:38:45 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:

> The cuckoo hash has a fixed number of entries per bucket, so the
> configuration parameter for this is unused. We change this field in the
> parameters struct to "reserved" to indicate that there is now no such
> parameter value, while at the same time keeping ABI consistency.
> 
> Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation")
> 
> Suggested-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

I am sorry this patch went into 2.1 because it broke source code
compatibility.  To me having source code recompile compatibility is MORE
important than ABI compatibility.