DPDK patches and discussions
 help / color / mirror / Atom feed
From: Simon Kagstrom <simon.kagstrom@netinsight.net>
To: dev@dpdk.org, nelio.laranjeiro@6wind.com,
	stephen@networkplumber.org, thomas.monjalon@6wind.com,
	bruce.richardson@intel.com
Subject: [dpdk-dev] [PATCH] mk: Quote $(KERNELCC) to allow ccache builds
Date: Thu, 24 Sep 2015 09:43:28 +0200	[thread overview]
Message-ID: <20150924094328.5a2ea3c8@miho> (raw)

Otherwise building with KERNELCC="ccache gcc" will fail:

 == Build lib/librte_eal/linuxapp/igb_uio
 /usr/src/linux-headers-3.13.0-63-generic/arch/x86/Makefile:98: stack protector enabled but no compiler support
 /usr/src/linux-headers-3.13.0-63-generic/arch/x86/Makefile:113: CONFIG_X86_X32 enabled but no binutils support
 ccache: invalid option -- 'p'
 Usage:
     ccache [options]
     ccache compiler [compiler options]
     compiler [compiler options]          (via symbolic link)

 Options:
     -c, --cleanup         delete old files and recalculate size counters
                           (normally not needed as this is done automatically)
     -C, --clear           clear the cache completely
     -F, --max-files=N     set maximum number of files in cache to N (use 0 for
                           no limit)
     -M, --max-size=SIZE   set maximum size of cache to SIZE (use 0 for no
                           limit; available suffixes: G, M and K; default
                           suffix: G)
     -s, --show-stats      show statistics summary
     -z, --zero-stats      zero statistics counters

     -h, --help            print this help text
     -V, --version         print version and copyright information

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
---
 mk/rte.module.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mk/rte.module.mk b/mk/rte.module.mk
index 7bf77c1..53ed4fe 100644
--- a/mk/rte.module.mk
+++ b/mk/rte.module.mk
@@ -78,7 +78,7 @@ build: _postbuild
 $(MODULE).ko: $(SRCS_LINKS)
 	@if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi
 	@$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \
-		CC=$(KERNELCC) CROSS_COMPILE=$(CROSS) V=$(if $V,1,0)
+		CC="$(KERNELCC)" CROSS_COMPILE=$(CROSS) V=$(if $V,1,0)
 
 # install module in $(RTE_OUTPUT)/kmod
 $(RTE_OUTPUT)/kmod/$(MODULE).ko: $(MODULE).ko
-- 
1.9.1

             reply	other threads:[~2015-09-24  7:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-24  7:43 Simon Kagstrom [this message]
2015-10-13 12:10 ` Simon Kagstrom
2015-10-13 12:26   ` Olivier MATZ
2015-10-13 12:39     ` Simon Kågström
2015-10-13 12:45       ` Thomas Monjalon
2015-10-13 12:54         ` Simon Kågström
2015-10-25 17:31     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150924094328.5a2ea3c8@miho \
    --to=simon.kagstrom@netinsight.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).