From: Stephen Hemminger <stephen@networkplumber.org>
To: Ravi Kerur <rkerur@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1] Move rte_mbuf macros to common header file
Date: Thu, 24 Sep 2015 16:25:37 -0700 [thread overview]
Message-ID: <20150924162537.3b20ea3a@urahara> (raw)
In-Reply-To: <1443135041-24757-1-git-send-email-rkerur@gmail.com>
On Thu, 24 Sep 2015 15:50:41 -0700
Ravi Kerur <rkerur@gmail.com> wrote:
> Macros RTE_MBUF_DATA_DMA_ADDR and RTE_MBUF_DATA_DMA_ADDR_DEFAULT
> are defined in each PMD driver file. Move those macros into common
> lib/librte_mbuf/rte_mbuf.h file. All PMD drivers include rte_mbuf.h
> file directly/indirectly hence no additionl header file inclusion
> is necessary.
>
> Compiled for:
> > x86_64-native-linuxapp-clang
> > x86_64-native-linuxapp-gcc
> > i686-native-linuxapp-gcc
> > x86_64-native-bsdapp-gcc
> > x86_64-native-bsdapp-clang
>
> Tested on:
> > x86_64 Ubuntu 14.04, testpmd and 'make test'
> > FreeBSD 10.1, testpmd
>
> Signed-off-by: Ravi Kerur <rkerur@gmail.com>
I like the idea, should have been done long ago.
My only gripe is that you should do this as inline functions
rather than macros. Inline functions are type safe, macros are not.
next prev parent reply other threads:[~2015-09-24 23:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 22:49 Ravi Kerur
2015-09-24 22:50 ` Ravi Kerur
2015-09-24 23:25 ` Stephen Hemminger [this message]
2015-09-26 2:46 ` Ravi Kerur
2015-09-29 9:55 ` Ananyev, Konstantin
2015-09-30 19:11 ` Ravi Kerur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150924162537.3b20ea3a@urahara \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=rkerur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).