From: Bruce Richardson <bruce.richardson@intel.com>
To: Zoltan Kiss <zoltan.kiss@linaro.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: prefetch cacheline after pointer becomes valid
Date: Fri, 25 Sep 2015 16:22:33 +0100 [thread overview]
Message-ID: <20150925152232.GA29324@bricha3-MOBL3> (raw)
In-Reply-To: <1443140606-18241-1-git-send-email-zoltan.kiss@linaro.org>
On Thu, Sep 24, 2015 at 05:23:26PM -0700, Zoltan Kiss wrote:
> At the original point the rx_pkts[pos( + n)] pointers are not initialized, so
> the code is prefetching random data.
>
> Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org>
>
Apart from the whitespace issues pointed out by John, this fix looks ok and
testing shows no performance impact (as expected).
/Bruce
next prev parent reply other threads:[~2015-09-25 15:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 0:23 Zoltan Kiss
2015-09-25 11:47 ` Mcnamara, John
2015-09-25 17:42 ` Zoltan Kiss
2015-09-25 15:22 ` Bruce Richardson [this message]
2015-09-25 17:44 ` [dpdk-dev] [PATCH v2] " Zoltan Kiss
2015-09-28 9:53 ` Bruce Richardson
2015-10-28 16:19 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150925152232.GA29324@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=zoltan.kiss@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).