From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C3BD18E56 for ; Fri, 25 Sep 2015 17:22:36 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 25 Sep 2015 08:22:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,587,1437462000"; d="scan'208";a="568387775" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.62]) by FMSMGA003.fm.intel.com with SMTP; 25 Sep 2015 08:22:33 -0700 Received: by (sSMTP sendmail emulation); Fri, 25 Sep 2015 16:22:33 +0025 Date: Fri, 25 Sep 2015 16:22:33 +0100 From: Bruce Richardson To: Zoltan Kiss Message-ID: <20150925152232.GA29324@bricha3-MOBL3> References: <1443140606-18241-1-git-send-email-zoltan.kiss@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443140606-18241-1-git-send-email-zoltan.kiss@linaro.org> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ixgbe: prefetch cacheline after pointer becomes valid X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Sep 2015 15:22:37 -0000 On Thu, Sep 24, 2015 at 05:23:26PM -0700, Zoltan Kiss wrote: > At the original point the rx_pkts[pos( + n)] pointers are not initialized, so > the code is prefetching random data. > > Signed-off-by: Zoltan Kiss > Apart from the whitespace issues pointed out by John, this fix looks ok and testing shows no performance impact (as expected). /Bruce