From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 55D8A1DB1 for ; Mon, 28 Sep 2015 12:23:35 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 28 Sep 2015 03:23:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,602,1437462000"; d="scan'208";a="814585350" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.62]) by orsmga002.jf.intel.com with SMTP; 28 Sep 2015 03:23:32 -0700 Received: by (sSMTP sendmail emulation); Mon, 28 Sep 2015 11:23:31 +0025 Date: Mon, 28 Sep 2015 11:23:31 +0100 From: Bruce Richardson To: dev@dpdk.org Message-ID: <20150928102331.GA29488@bricha3-MOBL3> References: <1434108496-1993-1-git-send-email-bruce.richardson@intel.com> <1441811374-28984-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441811374-28984-1-git-send-email-bruce.richardson@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 0/4] ethdev: minor cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Sep 2015 10:23:35 -0000 On Wed, Sep 09, 2015 at 04:09:30PM +0100, Bruce Richardson wrote: > This patchset performs two cleanups: > 1. Four functions in ethdev.c which were enabled for debug only have been > merged into their inlined header-file counterparts. This change required that > a number of macros be renamed and moved to the header file too. The macro changes > are in patches 1 & 2, and the elimination of the separate debug fns are in patch 3. > 2. Checks for valid function pointers are added to the API calls for reading > the descriptor ring count, and checking for a valid descriptor. This is because > these functions are not implemented by most drivers, and so it's far safer to > have the check. > > --- > > V2 Changes: > * Rebased to latest DPDK codebase > * Changed type from uint32_t to int for the count function, on the basis of > feedback received. > > Bruce Richardson (4): > ethdev: rename macros to have RTE_ETH prefix > ethdev: move error checking macros to header > ethdev: remove duplicated debug functions > ethdev: check driver support for functions > > lib/librte_ether/rte_ethdev.c | 674 ++++++++++++++++++------------------------ > lib/librte_ether/rte_ethdev.h | 121 ++++++-- > 2 files changed, 375 insertions(+), 420 deletions(-) > > -- Thomas, all, Any comments on this set? /Bruce