From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com
 [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id C4A105A44
 for <dev@dpdk.org>; Tue, 29 Sep 2015 18:14:56 +0200 (CEST)
Received: by padhy16 with SMTP id hy16so10242705pad.1
 for <dev@dpdk.org>; Tue, 29 Sep 2015 09:14:56 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=KGjuhxEqW2IiBIg7CqaojPgHuLQA2TJXKyNCBIZ36ak=;
 b=k9jYIoMjKMBk3IXmg3YRPtdNJBi5953Z93zpFTscxrDBLcmhl/hAhyZBZ20KfvflGI
 1tcW7ZQB7dYce/08BXxI5i4yVWoei6Pwjqc3pBnoUt4jDu3Y6Dns+mP4dff0mLYkqT7M
 smoh+kMWMF1C9TGdapskCeRf/48Jx6HvvO4ryZgRuY/k7lFES71talblCQBmTjDt3m1y
 Oa2aAcUbxZNV13KJ6vs4JWGaIY3t2S10XpDE89Lw/1zQWGXPwhGWER1utSAM/CgVRy4X
 FpC0te0wo0r+RFY8KP6YQyzw6igMK1n/xbjOtmQ6mAQhucM9tT8g7iqq0KdGEgKi053k
 BDPA==
X-Gm-Message-State: ALoCoQk4RXR2mrHrDGIyqEISaWb9pg+/NGmEVZWHyu4N1mMR5q4DwlkbE5XxQvfqTVgA8XRvi1MV
X-Received: by 10.68.92.194 with SMTP id co2mr34304383pbb.147.1443543296072;
 Tue, 29 Sep 2015 09:14:56 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id be6sm26528547pad.5.2015.09.29.09.14.55
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 29 Sep 2015 09:14:55 -0700 (PDT)
Date: Tue, 29 Sep 2015 09:15:05 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Huawei Xie <huawei.xie@intel.com>
Message-ID: <20150929091505.121c7078@urahara>
In-Reply-To: <1443537953-23917-4-git-send-email-huawei.xie@intel.com>
References: <1443537953-23917-1-git-send-email-huawei.xie@intel.com>
 <1443537953-23917-4-git-send-email-huawei.xie@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/8] virtio: add software rx ring, fake_buf,
 simple_rxtx into virtqueue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Sep 2015 16:14:57 -0000

On Tue, 29 Sep 2015 22:45:48 +0800
Huawei Xie <huawei.xie@intel.com> wrote:

> +		if (vq->sw_ring)
> +			rte_free(vq->sw_ring);

	rte_free of NULL is a nop so conditional here is unnecessary