From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
by dpdk.org (Postfix) with ESMTP id 3A20AB62
for <dev@dpdk.org>; Tue, 29 Sep 2015 16:38:27 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
by orsmga102.jf.intel.com with ESMTP; 29 Sep 2015 07:38:26 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,608,1437462000"; d="scan'208";a="815350899"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.61])
by fmsmga002.fm.intel.com with SMTP; 29 Sep 2015 07:38:24 -0700
Received: by (sSMTP sendmail emulation); Tue, 29 Sep 2015 15:38:23 +0025
Date: Tue, 29 Sep 2015 15:38:23 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Andrey Chilikin <andrey.chilikin@intel.com>
Message-ID: <20150929143823.GE6748@bricha3-MOBL3>
References: <1443536800-13269-1-git-send-email-andrey.chilikin@intel.com>
<1443536800-13269-2-git-send-email-andrey.chilikin@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1443536800-13269-2-git-send-email-andrey.chilikin@intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/3] librte_ether: add RTE_ETH_FDIR_OTHER for
flow director behavior
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Sep 2015 14:38:27 -0000
On Tue, Sep 29, 2015 at 03:26:38PM +0100, Andrey Chilikin wrote:
> Add new flow director behavior RTE_ETH_FDIR_OTHER to assign a queue by other filters
>
> Signed-off-by: Andrey Chilikin <andrey.chilikin@intel.com>
> ---
> lib/librte_ether/rte_eth_ctrl.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/lib/librte_ether/rte_eth_ctrl.h b/lib/librte_ether/rte_eth_ctrl.h
> index 26b7b33..3acf501 100644
> --- a/lib/librte_ether/rte_eth_ctrl.h
> +++ b/lib/librte_ether/rte_eth_ctrl.h
> @@ -417,6 +417,7 @@ struct rte_eth_fdir_input {
> enum rte_eth_fdir_behavior {
> RTE_ETH_FDIR_ACCEPT = 0,
> RTE_ETH_FDIR_REJECT,
> + RTE_ETH_FDIR_OTHER,
> };
>
> /**
> --
> 1.7.4.1
>
Is "OTHER" meant to be a "NOOP" or a generic hold-all for a set of other possible
behaviours. From the description, I would assume NOOP - in which case would
RTE_ETH_FDIR_NOOP not be a better name?
/Bruce