From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 4C02D8DAA for ; Wed, 30 Sep 2015 15:23:25 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 30 Sep 2015 06:23:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,612,1437462000"; d="scan'208";a="571318749" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.62]) by FMSMGA003.fm.intel.com with SMTP; 30 Sep 2015 06:23:22 -0700 Received: by (sSMTP sendmail emulation); Wed, 30 Sep 2015 14:23:21 +0025 Date: Wed, 30 Sep 2015 14:23:21 +0100 From: Bruce Richardson To: Neil Horman Message-ID: <20150930132321.GB11552@bricha3-MOBL3> References: <1443445418-18498-1-git-send-email-bernard.iremonger@intel.com> <1443445418-18498-3-git-send-email-bernard.iremonger@intel.com> <20150930131853.GB32524@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150930131853.GB32524@hmsreliant.think-freely.org> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 02/20] librte_ether: add fields from rte_pci_driver to rte_eth_dev_data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Sep 2015 13:23:25 -0000 On Wed, Sep 30, 2015 at 09:18:53AM -0400, Neil Horman wrote: > > +} > > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > > index fa06554..9cd262b 100644 > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > @@ -1635,8 +1635,23 @@ struct rte_eth_dev_data { > > all_multicast : 1, /**< RX all multicast mode ON(1) / OFF(0). */ > > dev_started : 1, /**< Device state: STARTED(1) / STOPPED(0). */ > > lro : 1; /**< RX LRO is ON(1) / OFF(0) */ > > + uint32_t dev_flags; /**< Flags controlling handling of device. */ > > + enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > > + int numa_node; > > + const char *drv_name; > > }; > > > Unrelated to my other questions on this code: Is rte_eth_dev_data ever > allocation by any applications? If so, this will have to go through the ABI > process. I don't think it is, but I wanted to ask to be sure > > Neil > No - applications do not allocate this structure directly, it's internal only, so we should be safe here from an ABI perspective. /Bruce