DPDK patches and discussions
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: Jasvinder Singh <jasvinder.singh@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] ip_pipeline: add more functions to routing-pipeline
Date: Thu, 1 Oct 2015 07:00:49 -0400	[thread overview]
Message-ID: <20151001110049.GB4537@hmsreliant.think-freely.org> (raw)
In-Reply-To: <1443690315-28489-1-git-send-email-jasvinder.singh@intel.com>

>  
>  /*
> @@ -106,9 +164,7 @@ struct pipeline_routing_route_add_msg_req {
>  	struct pipeline_routing_route_key key;
>  
>  	/* data */
> -	uint32_t flags;
> -	uint32_t port_id; /* Output port ID */
> -	uint32_t ip; /* Next hop IP address (only valid for remote routes) */
> +	struct pipeline_routing_route_data data;
>  };
>  

The example that you modifying appears to directly set the structure fields that
you removing above.  As such these appear to be ABI breaking changes and need to
go through the ABI process

Neil

  parent reply	other threads:[~2015-10-01 11:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30 15:20 [dpdk-dev] [PATCH] " Jasvinder Singh
2015-09-30 15:38 ` Dumitrescu, Cristian
2015-10-01  9:05   ` [dpdk-dev] [PATCH v2] " Jasvinder Singh
2015-10-01  9:09     ` Dumitrescu, Cristian
2015-10-01 11:00     ` Neil Horman [this message]
2015-10-01 12:37       ` Dumitrescu, Cristian
2015-10-01 17:18         ` Neil Horman
2015-10-19 10:59           ` [dpdk-dev] [PATCH v3] " Jasvinder Singh
2015-10-28 10:35             ` [dpdk-dev] [PATCH v4] " Jasvinder Singh
2015-12-02 10:22               ` [dpdk-dev] [PATCH v5] " Jasvinder Singh
2015-12-07  0:55                 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151001110049.GB4537@hmsreliant.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=dev@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).