From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by dpdk.org (Postfix) with ESMTP id 03F908E65 for ; Fri, 2 Oct 2015 00:00:29 +0200 (CEST) Received: by pacfv12 with SMTP id fv12so88084671pac.2 for ; Thu, 01 Oct 2015 15:00:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=eLxLEcvM6NJcVe0WVnbCO4ozGeovSZ3Vy1mFcTrpW7Q=; b=Rf6fsUtwSA12YQGjrx35dwgQZKrg1NxDitCXXtsBltEwv3QMUnuJwIvIseGkLCmUlg ZyxqiiMIplmC1w7vBrDspmE93PWsdcp5pk+IDLD19uzkzckd4Y1fpXhfVGawzj0gbn8R bVd6nEpj54Z8v/9L4iP3uFaz+4YBZkQ7sk+z53WHyu0qn7pYdRHI3zM0+D211u5mBL2v Q6ZOerhI+ADB8bJ+HJrYkKVPhqs7TKdzMUTTz6O0Lg9us+Dkv7Csqa/uHnsvE276t2tE MFPP5Z579rhYkCxoKaEd1j2bWEEJCjiXxnxy1n999ambBhsMgV9ylHSf5o/X2Wx5TCl4 M/PA== X-Gm-Message-State: ALoCoQnUGrIcKjzskOBiBBnTHQoTDsWkhgFGYyYpXs2JOnNntcjy8iW9/ic2X0QwtNr1Jvl5mVBR X-Received: by 10.66.219.8 with SMTP id pk8mr4839806pac.138.1443736827043; Thu, 01 Oct 2015 15:00:27 -0700 (PDT) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id xv12sm8606635pac.38.2015.10.01.15.00.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Oct 2015 15:00:26 -0700 (PDT) Date: Thu, 1 Oct 2015 15:00:36 -0700 From: Stephen Hemminger To: Alexander Duyck Message-ID: <20151001150036.7a20b228@urahara> In-Reply-To: <560D8E14.5030500@gmail.com> References: <1443652138-31782-1-git-send-email-stephen@networkplumber.org> <560D11F6.2080609@scylladb.com> <20151001075731.2f079237@urahara> <560D8E14.5030500@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Avi Kivity , hjk@hansjkoch.de, gregkh@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [dpdk-dev] [PATCH 0/2] uio_msi: device driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2015 22:00:29 -0000 On Thu, 1 Oct 2015 12:48:36 -0700 Alexander Duyck wrote: > On 10/01/2015 07:57 AM, Stephen Hemminger wrote: > > On Thu, 1 Oct 2015 13:59:02 +0300 > > Avi Kivity wrote: > > > >> On 10/01/2015 01:28 AM, Stephen Hemminger wrote: > >>> This is a new UIO device driver to allow supporting MSI-X and MSI devices > >>> in userspace. It has been used in environments like VMware and older versions > >>> of QEMU/KVM where no IOMMU support is available. > >> Why not add msi/msix support to uio_pci_generic? > > That is possible but that would meet ABI and other resistance from the author. > > Also, uio_pci_generic makes it harder to find resources since it doesn't fully > > utilize UIO infrastructure. > > I'd say you are better off actually taking this in the other direction. > From what I have seen it seems like this driver is meant to deal with > mapping VFs contained inside of guests. If you are going to fork off > and create a UIO driver for mapping VFs why not just make it specialize > in that. You could probably simplify the code by dropping support for > legacy interrupts and IO regions since all that is already covered by > uio_pci_generic anyway if I am not mistaken. > > You could then look at naming it something like uio_vf since the uio_msi > is a bit of a misnomer since it is MSI-X it supports, not MSI interrupts. The support needs to cover: - VF in guest - VNIC in guest (vmxnet3) it isn't just about VF's