From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id 9F6A48E61 for ; Fri, 2 Oct 2015 02:01:36 +0200 (CEST) Received: by pacfv12 with SMTP id fv12so90787322pac.2 for ; Thu, 01 Oct 2015 17:01:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=mMc6i8smrr78QDMZLHdHWIf4GBlQVB6tZx2es40vxO8=; b=kUBcOC0Kv0doJvCHscowXvV1yDZAZhHey+lecWdFncjuNhzHP1ilmObbqod5OK16Hb ABvBV/PlpHXIuiLKAW3FCQP80he91clxnPLonoPzHRvcN+1yRCecYxji4y+EgaZRSO2J 0U+c8wibs26C4NjDYNtNQwCB5kIPuLcc5ZUxuMWMbFxUELTjwTnHR2Uv2TF/v4IW2zTt UsPmlRXi3FDFFejNf+wNCOldvPWCdrb5FATEWGCblk2DLSL+8ADJl41ZGkzHPEd7/RGN 5dSRC3ix6ZOdqpth3CDhL1pfODLYFgplhJubTRHlwEFZIDJWopKdMkkLWCsT2ekWxJ/X KSEg== X-Gm-Message-State: ALoCoQkXXIKkahf6YZ32C34CulcP1xprhwudv6jg8uuyv+c/8tKrNyKfxOtx+Etc+4sNSjwZ57Fh X-Received: by 10.66.141.199 with SMTP id rq7mr15944440pab.140.1443744095961; Thu, 01 Oct 2015 17:01:35 -0700 (PDT) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id pk2sm8894560pbb.21.2015.10.01.17.01.35 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Oct 2015 17:01:35 -0700 (PDT) Date: Thu, 1 Oct 2015 17:01:45 -0700 From: Stephen Hemminger To: Alexander Duyck Message-ID: <20151001170145.4239de9f@urahara> In-Reply-To: <560DC45A.3050507@gmail.com> References: <1443652138-31782-1-git-send-email-stephen@networkplumber.org> <1443652138-31782-3-git-send-email-stephen@networkplumber.org> <560DC45A.3050507@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, hjk@hansjkoch.de, gregkh@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [dpdk-dev] [PATCH 2/2] uio: new driver to support PCI MSI-X X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2015 00:01:37 -0000 On Thu, 1 Oct 2015 16:40:10 -0700 Alexander Duyck wrote: > I agree with some other reviewers. Why call pci_enable_msix in open? > It seems like it would make much more sense to do this on probe, and > then disable MSI-X on free. I can only assume you are trying to do it > to save on resources but the fact is this is a driver you have to > explicitly force onto a device so you would probably be safe to assume > that they plan to use it in the near future. Because if interface is not up, the MSI handle doesn't have to be open. This saves resources and avoids some races.