From: Stephen Hemminger <stephen@networkplumber.org>
To: Maryam Tahhan <maryam.tahhan@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: remove the imissed deprecation tag
Date: Tue, 13 Oct 2015 08:53:15 -0700 [thread overview]
Message-ID: <20151013085315.7d27e903@xeon-e3> (raw)
In-Reply-To: <1443601256-181129-1-git-send-email-maryam.tahhan@intel.com>
On Wed, 30 Sep 2015 09:20:56 +0100
Maryam Tahhan <maryam.tahhan@intel.com> wrote:
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index fa06554..78bd94d 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -194,8 +194,7 @@ struct rte_eth_stats {
> uint64_t opackets; /**< Total number of successfully transmitted packets.*/
> uint64_t ibytes; /**< Total number of successfully received bytes. */
> uint64_t obytes; /**< Total number of successfully transmitted bytes. */
> - uint64_t imissed;
> - /**< Deprecated; Total of RX missed packets (e.g full FIFO). */
If you want to deprecate a structure field, it works better to mark
it with __attribute__((deprecated)) that way all use of that field in
code will be flagged.
Comments are advisory only and often never spotted.
prev parent reply other threads:[~2015-10-13 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 8:20 Maryam Tahhan
2015-10-13 13:57 ` Olivier MATZ
2015-10-13 15:53 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013085315.7d27e903@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=maryam.tahhan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).