From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com
 [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id 862DD5A63
 for <dev@dpdk.org>; Tue, 13 Oct 2015 17:53:07 +0200 (CEST)
Received: by pabve7 with SMTP id ve7so25295629pab.2
 for <dev@dpdk.org>; Tue, 13 Oct 2015 08:53:06 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=lqWwGRngc+Sck4xExLy166O3sDwIN976ufrvwvyI03U=;
 b=BSwPwDIH0ZNKFGhTDwCG1dIO1iLvfzPvPDCut/0lYypoQ2f4zdN/O/HqYunfvD/ewJ
 4nwskHGBMYAvt0/FAPVF6NxLXSffh0Kmy9XIiVrxWk+12mMMGDcOsL56XHWY5ELBTewF
 3N1oMTnw8NRJ8TyuE6/B2PyoUst7/QWz6U1t8+5px2ZjYRk/cyQQC7J+O9Rb5eX8xNf3
 lqSNE2CgnikThdJG/1m+Lk7BVNPV6a9La9cZOwYl1lavi5eCz1htIbgIK//zl/YJmsMl
 Z82KUZYsQTYetv9DW4h/l6k5If/30JQ27OkasdW/YH2FDAekWa4nvfp1M/ErjHw+uz5N
 o7gA==
X-Gm-Message-State: ALoCoQlF5dedN468jd/4th+T5Bt8SffTT0k0+jk/iIrdCOaxlRCSDEmul/Zy9E/3qbnoCL9nB8m8
X-Received: by 10.68.88.130 with SMTP id bg2mr34528237pbb.38.1444751586753;
 Tue, 13 Oct 2015 08:53:06 -0700 (PDT)
Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id iu2sm2243304pbd.16.2015.10.13.08.53.06
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 13 Oct 2015 08:53:06 -0700 (PDT)
Date: Tue, 13 Oct 2015 08:53:15 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Maryam Tahhan <maryam.tahhan@intel.com>
Message-ID: <20151013085315.7d27e903@xeon-e3>
In-Reply-To: <1443601256-181129-1-git-send-email-maryam.tahhan@intel.com>
References: <1443601256-181129-1-git-send-email-maryam.tahhan@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: remove the imissed deprecation tag
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Oct 2015 15:53:08 -0000

On Wed, 30 Sep 2015 09:20:56 +0100
Maryam Tahhan <maryam.tahhan@intel.com> wrote:

> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index fa06554..78bd94d 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -194,8 +194,7 @@ struct rte_eth_stats {
>  	uint64_t opackets;  /**< Total number of successfully transmitted packets.*/
>  	uint64_t ibytes;    /**< Total number of successfully received bytes. */
>  	uint64_t obytes;    /**< Total number of successfully transmitted bytes. */
> -	uint64_t imissed;
> -	/**< Deprecated; Total of RX missed packets (e.g full FIFO). */

If you want to deprecate a structure field, it works better to mark
it with __attribute__((deprecated)) that way all use of that field in
code will be flagged.

Comments are advisory only and often never spotted.