From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) by dpdk.org (Postfix) with ESMTP id BB6848D8B for ; Wed, 14 Oct 2015 18:08:53 +0200 (CEST) Received: by padcn9 with SMTP id cn9so27196771pad.2 for ; Wed, 14 Oct 2015 09:08:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=S8n8sMBM6U26kr5dMnxNe2HIASuGT5T5DHHAmvDuRN0=; b=C9DIsooRIdr6cGzwF7VZP9LKUvoqJGT0YDUAwzdmX5mL+YZgfoFwTwZ93vZyn6Avx3 8ad7YDeDZfF0dFwu8kQHFDOH8BVRtY1hbs2pTBgJsutTJDfBr5m28lN4k0by5P0kfp5g ED5HtysDZPc6OTEHY7vQf0fkPXRwyuSWWq+Uo0L2FZVrUxD+1jazrndV9Vaji7SIhScx NOWBH14NAKbIDVUWzkGy3U0xtnwvfmeYplMTGDVycMrngC7lLvy7ls+CzHYG0l+sPNJQ G20gvW+y88PwnWDr/aTQkl36xgU2h+CcBxJwRWVI+LDtdlt5VT3GNa4z0SXZTPKUUo1N nwTg== X-Gm-Message-State: ALoCoQnBhyt6+0ctq493V4ZRoZrphYW0nUdKcK96CsRDockJkgYfWjPTwJK7XmZFeTosOwOml3JG X-Received: by 10.68.190.170 with SMTP id gr10mr4346151pbc.91.1444838933115; Wed, 14 Oct 2015 09:08:53 -0700 (PDT) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id dg2sm10489930pbb.9.2015.10.14.09.08.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Oct 2015 09:08:52 -0700 (PDT) Date: Wed, 14 Oct 2015 09:09:04 -0700 From: Stephen Hemminger To: Konstantin Ananyev Message-ID: <20151014090904.3d632d92@xeon-e3> In-Reply-To: <1443729293-20753-2-git-send-email-konstantin.ananyev@intel.com> References: <1443729293-20753-1-git-send-email-konstantin.ananyev@intel.com> <1443729293-20753-2-git-send-email-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCHv5 1/8] ethdev: add new API to retrieve RX/TX queue information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2015 16:08:54 -0000 On Thu, 1 Oct 2015 20:54:46 +0100 Konstantin Ananyev wrote: > + if (nb_rx_desc > dev_info.rx_desc_lim.nb_max || > + nb_rx_desc < dev_info.rx_desc_lim.nb_min || > + nb_rx_desc % dev_info.rx_desc_lim.nb_align != 0) { > + Preferred indentation style is to line up the conditional. if (nb_rx_desc > dev_info.rx_desc_lim.nb_max || nb_rx_desc < dev_info.rx_desc_lim.nb_min || nb_rx_desc % dev_info.rx_desc_lim.nb_align != 0) {