From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ustc.edu.cn (smtp2.ustc.edu.cn [202.38.64.46]) by dpdk.org (Postfix) with ESMTP id 598975693 for ; Wed, 14 Oct 2015 13:28:28 +0200 (CEST) Received: from dell (unknown [222.195.92.204]) by newmailweb.ustc.edu.cn (Coremail) with SMTP id LkAmygDn1whVPB5WwwqyAQ--.38419S2; Wed, 14 Oct 2015 19:28:25 +0800 (CST) Date: Wed, 14 Oct 2015 19:28:13 +0800 From: Tiwei Bie To: Bruce Richardson Message-ID: <20151014112813.GA1514@dell> References: <1444726446-8106-1-git-send-email-btw@mail.ustc.edu.cn> <1444726446-8106-2-git-send-email-btw@mail.ustc.edu.cn> <20151014022843.GA26774@dell> <20151014093128.GC32308@bricha3-MOBL3> <20151014101933.GB68200@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20151014101933.GB68200@dell> User-Agent: Mutt/1.5.24 (2015-08-30) X-CM-TRANSID: LkAmygDn1whVPB5WwwqyAQ--.38419S2 X-Coremail-Antispam: 1UD129KBjvJXoWxJF4fWw15KFy7tw1kWrW3Wrg_yoWrur4Dp3 47WF1jkF4kJrWIyr1qqw1DJr1Fy348KFy8WF9Yy34kCFnIyFyktF1UtrWY9F4furs8AFW0 vr4Ivay7ua15ZFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUk0b7Iv0xC_KF4lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I 8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI 64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVW8JVWxJw Am72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc2xSY4AK67AK6r4kMxAIw28IcxkI 7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxV Cjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUXVWUAwCIc40Y0x0EwIxGrwCI42IY 6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6x AIw20EY4v20xvaj40_WFyUJVCq3wCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv 6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUI2-nDUUUU X-CM-SenderInfo: xewzqzxdloh3xvwfhvlgxou0/1tbiAQcCAVQhmEgJgQAQs4 Cc: "dev@dpdk.org" , Don Provan Subject: Re: [dpdk-dev] [PATCH] eal/bsd: reinitialize optind and optreset to 1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2015 11:28:29 -0000 On Wed, Oct 14, 2015 at 06:19:33PM +0800, Tiwei Bie wrote: > On Wed, Oct 14, 2015 at 10:31:28AM +0100, Bruce Richardson wrote: > > On Wed, Oct 14, 2015 at 10:28:44AM +0800, Tiwei Bie wrote: > > > On Tue, Oct 13, 2015 at 05:14:38PM +0000, Don Provan wrote: > > > > Actually, this is a good opportunity to fix a bug that's been in this code forever: it shouldn't be resetting optind to some arbitrary value: it should be saving optind (and optarg and optopt) at the beginning, initializing optind to 1 before calling getopt_long(), then restoring all the values after. (And, from what you're saying, optreset should be handled the same as optind.) > > > > > > > > > > It is designed to have DPDK's parameters specified in the front of the > > > cmd line and terminated by '--'. Or at least, you should put DPDK's > > > parameters together and terminate them by '--'. And 1 or 0 are not some > > > arbitrary values. They are used to put the index back to the beginning > > > of the new argv[] array. > > > > > > > This avoids broken behavior if rte_eal_init() is called by code that's in the middle of using getopt() to parse its own unrelated argc/argv parameters. > > > > > > > > > > We shouldn't mix up DPDK's parameters and application's parameters. > > > And we should group them using '--'. > > > > > > Best, > > > Tiwei Bie > > > > While true, that does not prevent us from implementing Don's suggestion, as it > > should fix the bug you are looking at with your original patch, and also allow > > additional use-cases for applications at no extra cost. > > > > As I understand it, what Don wants is something like this: > > int main(int argc, char **argv) > { > int ret; > int ch; > > while ((ch = getopt(argc, argv, "whateveroptions:d")) != -1) { > switch (ch) { > case 'd': > /* rte_eal_init() will be called */ > ret = dpdk_init(argc, argv); > argc -= ret; > argv += ret; > break; > case 'w': > ...... > } > } > > argc -= optind; > argv += optind; > > ...... > } > > static int > dpdk_init(int argc, char **argv) > { > int ret; > > ret = rte_eal_init(argc, argv); > if (ret < 0) > FATAL_ERROR("Could not initialise EAL (%d)", ret); > > ...... > > return (ret); > } > > And the current code should work correctly if DPDK's parameters are > put together and terminated by '--': > > $ ./demo -whatever -d -c f -n 2 -- -option -s hello > eal_log_level_parse() needs to be reworked to make the code work correctly. > The only limitation is that the return value of rte_eal_init() must > be returned to the code which is using getopt() to parse argc/argv. > > And I'm very willing to rework my patch to get rid of this limitation. > I'm considering updating optind to make it point to the option after '--' before eal_parse_args() returns, and eal_parse_args() will return 0 to avoid breaking the current applications which use the return value of rte_eal_init() to update argc/argv. Any comments? Thanks! :-) Best regards, Tiwei Bie > Best regards, > Tiwei Bie > > > /Bruce > > > > > > > > > -don provan > > > > dprovan@bivio.net > > > > > > > > -----Original Message----- > > > > From: Tiwei Bie [mailto:btw@mail.ustc.edu.cn] > > > > Sent: Tuesday, October 13, 2015 1:54 AM > > > > To: dev@dpdk.org > > > > Subject: [dpdk-dev] [PATCH] eal/bsd: reinitialize optind and optreset to 1 > > > > > > > > The variable optind must be reinitialized to 1 in order to skip over argv[0] on FreeBSD. Because getopt() on FreeBSD will return -1 when it meets an argument which doesn't start with '-'. > > > > > > > > The variable optreset is provided on FreeBSD to indicate the additional set of calls to getopt(). So, also reinitialize it to 1. > > > > > > > > Signed-off-by: Tiwei Bie > > > > --- > > > > lib/librte_eal/bsdapp/eal/eal.c | 6 ++++-- > > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c index 1b6f705..35feaee 100644 > > > > --- a/lib/librte_eal/bsdapp/eal/eal.c > > > > +++ b/lib/librte_eal/bsdapp/eal/eal.c > > > > @@ -334,7 +334,8 @@ eal_log_level_parse(int argc, char **argv) > > > > break; > > > > } > > > > > > > > - optind = 0; /* reset getopt lib */ > > > > + optind = 1; /* reset getopt lib */ > > > > + optreset = 1; > > > > } > > > > > > > > /* Parse the argument given in the command line of the application */ @@ -403,7 +404,8 @@ eal_parse_args(int argc, char **argv) > > > > if (optind >= 0) > > > > argv[optind-1] = prgname; > > > > ret = optind-1; > > > > - optind = 0; /* reset getopt lib */ > > > > + optind = 1; /* reset getopt lib */ > > > > + optreset = 1; > > > > return ret; > > > > } > > > > > > > > -- > > > > 2.6.0 > > > > > > > > > > > > > > >