From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id CB1A98D95 for ; Fri, 16 Oct 2015 15:00:03 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 16 Oct 2015 05:59:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,689,1437462000"; d="scan'208";a="582126795" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.62]) by FMSMGA003.fm.intel.com with SMTP; 16 Oct 2015 05:59:55 -0700 Received: by (sSMTP sendmail emulation); Fri, 16 Oct 2015 13:59:54 +0025 Date: Fri, 16 Oct 2015 13:59:53 +0100 From: Bruce Richardson To: Panu Matilainen Message-ID: <20151016125953.GC9980@bricha3-MOBL3> References: <42ab5ad11b473b964faaa2b0c622b92085d2545a.1444996480.git.pmatilai@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42ab5ad11b473b964faaa2b0c622b92085d2545a.1444996480.git.pmatilai@redhat.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 4/5] eal: add an error code to plugin init for the next step X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Oct 2015 13:00:04 -0000 On Fri, Oct 16, 2015 at 02:58:16PM +0300, Panu Matilainen wrote: > Signed-off-by: Panu Matilainen > --- > lib/librte_eal/bsdapp/eal/eal.c | 3 ++- > lib/librte_eal/common/eal_common_options.c | 3 ++- > lib/librte_eal/common/eal_options.h | 2 +- > lib/librte_eal/linuxapp/eal/eal.c | 3 ++- > 4 files changed, 7 insertions(+), 4 deletions(-) Again, another minor nit, but couldn't this be done when refactoring in previous patches, rather than needed a whole separate commit ? /Bruce