From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 009CBCF9 for ; Fri, 16 Oct 2015 17:28:28 +0200 (CEST) Received: by wijq8 with SMTP id q8so16390443wij.0 for ; Fri, 16 Oct 2015 08:28:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=MCgirOgXAdvv0tHaBYdH0nYAnxl1ZDQdrKaC5bHLUAI=; b=VUw43ODMnXuJ/MSF8tkp782YAniWeX5+vEVqVRL2oMXokX4UntgpDg9TaWgs2oO1TL dQRPuTUV2cATwy/VoNSapTrvTrhBdogSlOZeLoPoqlmSYKwXUKMsshXqoZbwsUZktpNM IMBkzyo5zW3v7lPDpY7SNciVnmFErjJcJ95ka7lhH0wjMsRQEZ07je9nln5XYlIpwu5G PsQDvhc3ZV29C1nz3a6wSBLYK5wBHRe+uSp4kWcBaqcyHCkKfdfzVxaRcYF9G/hAg2kn W8kJXKELItHw6nPVufAJAf61QXM8KMTuK/tT4Hynav4SlFYgQ0KHw1TDVUvgDeMGiv2u LjCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=MCgirOgXAdvv0tHaBYdH0nYAnxl1ZDQdrKaC5bHLUAI=; b=PwMlfSmFnaeJYrSiDZFa5SlI4U9Pimz+9n6/E/W62Ad3wURT9ntW8AL/ZgxtB+uP4u y4s3lnV4bFeoo+TaY3pZecXcXaxlIjulP6lZLNJfCWweYWYbudXN3FkjZs/l/St1V09I SSanG01fzG/GxcCu6CcivxtX2g82TS2D7yyvpY0jhREbu0/wb2Gcsg4HbWwS5Fzcatsh NkFSsCZmjpYwi7+zzNKOoit5mz1rQJ6sRiEl3668DCVRzNBfP2kxWkB9Y9m55qbH7i8Q 2XYzLOh6F1fRfiHou7uzDgv215rAvUtfuKcc0CQTLN+Lvpr0B5SJ8C+hM5LSMuPquzo7 ypcg== X-Gm-Message-State: ALoCoQnmu8zg0PcW+40bw7E7Cj1VKP1zMnUphkwCw54ZmJZcvDy6E7rq7mP9zFy4Ofi8P+y72XDA X-Received: by 10.194.22.69 with SMTP id b5mr17429568wjf.157.1445009308750; Fri, 16 Oct 2015 08:28:28 -0700 (PDT) Received: from autoinstall.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id uq5sm23120149wjc.3.2015.10.16.08.28.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Oct 2015 08:28:28 -0700 (PDT) Date: Fri, 16 Oct 2015 17:28:10 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: "Lu, Wenzhuo" Message-ID: <20151016152810.GD2594@autoinstall.dev.6wind.com> References: <6A0DE07E22DDAD4C9103DF62FEBC09090209FB49@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090209FB49@shsmsx102.ccr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] RSS API discussion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Oct 2015 15:28:29 -0000 On Fri, Oct 16, 2015 at 01:40:00PM +0000, Lu, Wenzhuo wrote: > Hi Nélio, > > > Hi Wenzhuo, > > > > We should discuss about this API for a future release of DPDK because this one > > lacks in flexibility. Some other NICs have indirection tables with a > > different/configurable size, and the current API does not help to manage it. > > > > For ConnectX-4 I have made a lot of hacks to avoid changing the DPDK API, > > "[dpdk-dev] [PATCH 0/3] Add RETA configuration to MLX5". > > http://dpdk.org/ml/archives/dev/2015-October/024681.html > > > > From a user point of view, to update the RETA table, the API expects the user to > > know the size of it to update or query. With your patchset, Intel have two > > indirection table sizes now, with Mellanox ConnectX-4, I fixed to the size of 512 > > entries because it is not fixed by default. > > > > How about discussing this in a separate thread? > Sure, I changed the tittle. > But I'm afraid I don't catch up with you. I have 2 questions, 1, Why the reta size cannot be predict on Mellanox ConnectX-4? 2, I don't understand the meaning when you say the reta size is not fixed by default on Mellanox ConnectX-4. > Would you like to give more details of the Mellanox ConnectX-4's behavior? It'll be helpful to understand this problem. On Connexct-4 we can configure the indirection table size with any power of two up to 512 entries. The current API only expects RETA tables size to be a multiple of RTE_RETA_GROUP_SIZE i.e. 64. To handle any kind of NICs, a simple array of N (RETA table size) elements with the data, instead of something in multiple of 64 would be easier to use, something like: struct rte_eth_rss_reta_entry { uint16_t idx; /* index to query/update. */ uint16_t reta; /* redirection value. */ }; We should update the API to take an array of such entries plus its size. It would also make update and query easier. -- Nélio Laranjeiro 6WIND