* [dpdk-dev] [PATCH] rte_ether: clarify rte_eth_set_queue_rate_limit tx_rate parameter
@ 2015-10-20 13:20 Simon Kagstrom
2015-11-04 7:51 ` Simon Kågström
2015-11-04 22:01 ` Thomas Monjalon
0 siblings, 2 replies; 4+ messages in thread
From: Simon Kagstrom @ 2015-10-20 13:20 UTC (permalink / raw)
To: thomas.monjalon; +Cc: dev
The tx_rate unit is Mbps.
Gleaned from the ixgbe implementation, the 82599 datasheet and the use
in test-pmd.
Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
---
lib/librte_ether/rte_ethdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 8a8c82b..ff9aab7 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -3021,7 +3021,7 @@ int rte_eth_mirror_rule_reset(uint8_t port_id,
* @param queue_idx
* The queue id.
* @param tx_rate
- * The tx rate allocated from the total link speed for this queue.
+ * The tx rate in Mbps. Allocated from the total port link speed.
* @return
* - (0) if successful.
* - (-ENOTSUP) if hardware doesn't support this feature.
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] rte_ether: clarify rte_eth_set_queue_rate_limit tx_rate parameter
2015-10-20 13:20 [dpdk-dev] [PATCH] rte_ether: clarify rte_eth_set_queue_rate_limit tx_rate parameter Simon Kagstrom
@ 2015-11-04 7:51 ` Simon Kågström
2015-11-04 18:15 ` Stephen Hemminger
2015-11-04 22:01 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Simon Kågström @ 2015-11-04 7:51 UTC (permalink / raw)
To: thomas.monjalon; +Cc: dev
Ping?
// Simon
On 2015-10-20 15:20, Simon Kagstrom wrote:
> The tx_rate unit is Mbps.
>
> Gleaned from the ixgbe implementation, the 82599 datasheet and the use
> in test-pmd.
>
> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> ---
> lib/librte_ether/rte_ethdev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index 8a8c82b..ff9aab7 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -3021,7 +3021,7 @@ int rte_eth_mirror_rule_reset(uint8_t port_id,
> * @param queue_idx
> * The queue id.
> * @param tx_rate
> - * The tx rate allocated from the total link speed for this queue.
> + * The tx rate in Mbps. Allocated from the total port link speed.
> * @return
> * - (0) if successful.
> * - (-ENOTSUP) if hardware doesn't support this feature.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] rte_ether: clarify rte_eth_set_queue_rate_limit tx_rate parameter
2015-11-04 7:51 ` Simon Kågström
@ 2015-11-04 18:15 ` Stephen Hemminger
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2015-11-04 18:15 UTC (permalink / raw)
To: Simon Kågström; +Cc: dev
On Wed, 4 Nov 2015 08:51:03 +0100
Simon Kågström <simon.kagstrom@netinsight.net> wrote:
> Ping?
>
> // Simon
>
> On 2015-10-20 15:20, Simon Kagstrom wrote:
> > The tx_rate unit is Mbps.
> >
> > Gleaned from the ixgbe implementation, the 82599 datasheet and the use
> > in test-pmd.
> >
> > Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> > ---
> > lib/librte_ether/rte_ethdev.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> > index 8a8c82b..ff9aab7 100644
> > --- a/lib/librte_ether/rte_ethdev.h
> > +++ b/lib/librte_ether/rte_ethdev.h
> > @@ -3021,7 +3021,7 @@ int rte_eth_mirror_rule_reset(uint8_t port_id,
> > * @param queue_idx
> > * The queue id.
> > * @param tx_rate
> > - * The tx rate allocated from the total link speed for this queue.
> > + * The tx rate in Mbps. Allocated from the total port link speed.
> > * @return
> > * - (0) if successful.
> > * - (-ENOTSUP) if hardware doesn't support this feature.
> >
You can check for status of any/all patches in patchwork:
http://dpdk.org/dev/patchwork/project/dpdk/list/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] rte_ether: clarify rte_eth_set_queue_rate_limit tx_rate parameter
2015-10-20 13:20 [dpdk-dev] [PATCH] rte_ether: clarify rte_eth_set_queue_rate_limit tx_rate parameter Simon Kagstrom
2015-11-04 7:51 ` Simon Kågström
@ 2015-11-04 22:01 ` Thomas Monjalon
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2015-11-04 22:01 UTC (permalink / raw)
To: Simon Kagstrom; +Cc: dev
2015-10-20 15:20, Simon Kagstrom:
> The tx_rate unit is Mbps.
>
> Gleaned from the ixgbe implementation, the 82599 datasheet and the use
> in test-pmd.
>
> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-04 22:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-20 13:20 [dpdk-dev] [PATCH] rte_ether: clarify rte_eth_set_queue_rate_limit tx_rate parameter Simon Kagstrom
2015-11-04 7:51 ` Simon Kågström
2015-11-04 18:15 ` Stephen Hemminger
2015-11-04 22:01 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).