From: Stephen Hemminger <stephen@networkplumber.org>
To: Dex Chen <dex.chen@ruckuswireless.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: allow per-net instances
Date: Wed, 21 Oct 2015 09:22:02 -0700 [thread overview]
Message-ID: <20151021092202.0fd6932a@xeon-e3> (raw)
In-Reply-To: <1435831933-13339-1-git-send-email-dex.chen@ruckuswireless.com>
On Thu, 2 Jul 2015 18:12:13 +0800
Dex Chen <dex.chen@ruckuswireless.com> wrote:
> +static __net_exit void kni_exit_net(struct net *net)
> +{
> + /*
> + * Nothing to do here.
> + * Assuming all cleanup jobs were done in kni_release().
> + */
> +}
I don't think you need an exit stub. Looks like kernel does
the right thing if it is just NULL.
Since this is kernel code, it should pass the kernel checkpatch.
$ checkpatch.pl /tmp/kni-netns.patch WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#84: FILE: lib/librte_eal/linuxapp/kni/kni_misc.c:99:
+ volatile unsigned long device_in_use; /* device in use flag */
WARNING: line over 80 characters
#166: FILE: lib/librte_eal/linuxapp/kni/kni_misc.c:196:
+ /* kni device can be opened by one user only per netns, test and set bit */
WARNING: line over 80 characters
#256: FILE: lib/librte_eal/linuxapp/kni/kni_misc.c:353:
+kni_ioctl_create(struct net *net, unsigned int ioctl_num, unsigned long ioctl_param)
WARNING: line over 80 characters
#319: FILE: lib/librte_eal/linuxapp/kni/kni_misc.c:544:
+kni_ioctl_release(struct net *net, unsigned int ioctl_num, unsigned long ioctl_param)
total: 0 errors, 4 warnings, 285 lines checked
/tmp/kni-netns.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
next prev parent reply other threads:[~2015-10-21 16:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 10:12 Dex Chen
2015-10-21 15:40 ` Thomas Monjalon
2015-10-21 16:22 ` Stephen Hemminger [this message]
2015-10-22 3:28 ` Zhang, Helin
2015-10-26 10:41 ` [dpdk-dev] [PATCH v2] " Dex Chen
2015-10-27 2:56 ` [dpdk-dev] [PATCH v3] " Dex Chen
2015-10-27 3:03 ` Zhang, Helin
2015-11-04 1:29 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021092202.0fd6932a@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=dex.chen@ruckuswireless.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).