From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by dpdk.org (Postfix) with ESMTP id EF272C3D0 for ; Wed, 21 Oct 2015 18:21:52 +0200 (CEST) Received: by padhk11 with SMTP id hk11so59019442pad.1 for ; Wed, 21 Oct 2015 09:21:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=1ou0Dkg3qPT90jecXvU+dZZDyllJRFs/0lEYFKGYs/0=; b=er4GT+RFK/BzPKXWwpLSxaWCJSpNQpN79cULIJ6fKAKEdbGfugbnUx5PhYlJflZDN5 H9Djt8FbY/TaSOKRXaDiuA9fF0RippONZsyJ9gEfiFxnmGzUCQhLnuPp8kYF1T2LWPia lWo+qoH8Wi4xe/jXjV0pAiZ8oQ58KnA4UwwWNeAOor9b+sqQsikd/DA8f41Q/UYkBUGP zLie+agqZPS0BN0SflE3KYwDll3nGeMxpVMC9YgtR6ZoPM3jZfFCYkj4KUoUoFq1ARnt DrA9VPW83ux62eoKk61/K7Bs+w1IYpk/xJHHurN7hkinq3HAX82SLeUwsOmeaXNKTmWY 4Jqw== X-Gm-Message-State: ALoCoQnBNZkpojMguO2OGsReqIRFAu1EzyoLESnXiPMXocdueqErIiw2w9ToMn1gAfsPwrUqeYuW X-Received: by 10.66.250.197 with SMTP id ze5mr11711669pac.50.1445444512265; Wed, 21 Oct 2015 09:21:52 -0700 (PDT) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id nu5sm9945181pbb.65.2015.10.21.09.21.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Oct 2015 09:21:52 -0700 (PDT) Date: Wed, 21 Oct 2015 09:22:02 -0700 From: Stephen Hemminger To: Dex Chen Message-ID: <20151021092202.0fd6932a@xeon-e3> In-Reply-To: <1435831933-13339-1-git-send-email-dex.chen@ruckuswireless.com> References: <1435831933-13339-1-git-send-email-dex.chen@ruckuswireless.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] kni: allow per-net instances X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2015 16:21:53 -0000 On Thu, 2 Jul 2015 18:12:13 +0800 Dex Chen wrote: > +static __net_exit void kni_exit_net(struct net *net) > +{ > + /* > + * Nothing to do here. > + * Assuming all cleanup jobs were done in kni_release(). > + */ > +} I don't think you need an exit stub. Looks like kernel does the right thing if it is just NULL. Since this is kernel code, it should pass the kernel checkpatch. $ checkpatch.pl /tmp/kni-netns.patch WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #84: FILE: lib/librte_eal/linuxapp/kni/kni_misc.c:99: + volatile unsigned long device_in_use; /* device in use flag */ WARNING: line over 80 characters #166: FILE: lib/librte_eal/linuxapp/kni/kni_misc.c:196: + /* kni device can be opened by one user only per netns, test and set bit */ WARNING: line over 80 characters #256: FILE: lib/librte_eal/linuxapp/kni/kni_misc.c:353: +kni_ioctl_create(struct net *net, unsigned int ioctl_num, unsigned long ioctl_param) WARNING: line over 80 characters #319: FILE: lib/librte_eal/linuxapp/kni/kni_misc.c:544: +kni_ioctl_release(struct net *net, unsigned int ioctl_num, unsigned long ioctl_param) total: 0 errors, 4 warnings, 285 lines checked /tmp/kni-netns.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.