From: Bruce Richardson <bruce.richardson@intel.com>
To: Yoni Fogel <yrobot@amazon.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib: rte_*_create gives NULL/EEXIST on duped name
Date: Wed, 21 Oct 2015 11:59:03 +0100 [thread overview]
Message-ID: <20151021105903.GC16140@bricha3-MOBL3> (raw)
In-Reply-To: <1445372497-817-1-git-send-email-yrobot@amazon.com>
On Tue, Oct 20, 2015 at 01:21:37PM -0700, Yoni Fogel wrote:
> Also fixed a bug in many of them where if the rte_malloc of
> the TAILQ fails, then we return a pointer to some arbitrary
> existing struct.
>
> Signed-off-by: Yoni Fogel <yrobot@amazon.com>
Thanks, looks like good fixes. However, I think for fixes like these they are
better as one-fix-per-patch, because in this case we have the title referring
to one fix, while the comment log describes a completely separate fix.
Can you perhaps do a V2 as a two-patch set?
/Bruce
> ---
> lib/librte_acl/rte_acl.c | 53 +++++++++++++++++++++------------------
> lib/librte_hash/rte_cuckoo_hash.c | 6 +++--
> lib/librte_hash/rte_fbk_hash.c | 5 +++-
> lib/librte_lpm/rte_lpm.c | 5 +++-
> lib/librte_lpm/rte_lpm6.c | 5 +++-
> 5 files changed, 44 insertions(+), 30 deletions(-)
>
next prev parent reply other threads:[~2015-10-21 10:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 20:21 Yoni Fogel
2015-10-21 10:59 ` Bruce Richardson [this message]
2015-10-21 12:04 ` Ananyev, Konstantin
-- strict thread matches above, loose matches on Subject: below --
2015-09-18 17:52 Yoni Fogel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021105903.GC16140@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=yrobot@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).