From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 12B68940A for ; Wed, 21 Oct 2015 12:59:16 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 21 Oct 2015 03:59:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,711,1437462000"; d="scan'208";a="831632666" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.65]) by orsmga002.jf.intel.com with SMTP; 21 Oct 2015 03:59:05 -0700 Received: by (sSMTP sendmail emulation); Wed, 21 Oct 2015 11:59:03 +0025 Date: Wed, 21 Oct 2015 11:59:03 +0100 From: Bruce Richardson To: Yoni Fogel Message-ID: <20151021105903.GC16140@bricha3-MOBL3> References: <1445372497-817-1-git-send-email-yrobot@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445372497-817-1-git-send-email-yrobot@amazon.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] lib: rte_*_create gives NULL/EEXIST on duped name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2015 10:59:17 -0000 On Tue, Oct 20, 2015 at 01:21:37PM -0700, Yoni Fogel wrote: > Also fixed a bug in many of them where if the rte_malloc of > the TAILQ fails, then we return a pointer to some arbitrary > existing struct. > > Signed-off-by: Yoni Fogel Thanks, looks like good fixes. However, I think for fixes like these they are better as one-fix-per-patch, because in this case we have the title referring to one fix, while the comment log describes a completely separate fix. Can you perhaps do a V2 as a two-patch set? /Bruce > --- > lib/librte_acl/rte_acl.c | 53 +++++++++++++++++++++------------------ > lib/librte_hash/rte_cuckoo_hash.c | 6 +++-- > lib/librte_hash/rte_fbk_hash.c | 5 +++- > lib/librte_lpm/rte_lpm.c | 5 +++- > lib/librte_lpm/rte_lpm6.c | 5 +++- > 5 files changed, 44 insertions(+), 30 deletions(-) >