From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by dpdk.org (Postfix) with ESMTP id 9A5A6C3A0 for ; Thu, 22 Oct 2015 17:57:45 +0200 (CEST) Received: by pabrc13 with SMTP id rc13so89957273pab.0 for ; Thu, 22 Oct 2015 08:57:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=liHkUEd7bHNWqNlzON6W5NLvLQjKIRBQxpQmopSYFAw=; b=U5xOaeaGJd34pHy9GZIP7nz4V5umZFRIHuzNewQMMwMS+XfdsmTJmMgAeq6riFYC4L i9GJyIBfpVhId5TZIMGblvKyckfVs86T3/RHfGM9jKjjRYpMWMOwZBo577YANyw4Lukg dTOB4205fbO48MBg5RVL7wGTweJfnCcD4/EapbRowOuaFItqxGoQ/aYYM6k3t9UgaUf1 SHLlMYMzS1WjWIbVvUPjl1GmZTb61WpRegujKqodj4xuKSlnREs7wwIQFe4GoNy35GAy 1w0VhlXT56IhnZKdpa67GioVoGW5reI9bnDsOCu9Hz0oDOwYU9uq50fE8QacVcLSHxiA G1kQ== X-Gm-Message-State: ALoCoQlHfe1WlE3wQIC72jJweSlDFkuAZO1O3JHI5C3BrrDO48XUeXmgNx3eKI1GYWQnTApqnH0j X-Received: by 10.68.68.233 with SMTP id z9mr18312974pbt.132.1445529464977; Thu, 22 Oct 2015 08:57:44 -0700 (PDT) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id hq1sm14529670pbb.43.2015.10.22.08.57.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Oct 2015 08:57:44 -0700 (PDT) Date: Thu, 22 Oct 2015 08:57:54 -0700 From: Stephen Hemminger To: "Chen Jing D(Mark)" Message-ID: <20151022085754.17478c99@xeon-e3> In-Reply-To: <1445507104-22563-4-git-send-email-jing.d.chen@intel.com> References: <1443531824-22767-2-git-send-email-jing.d.chen@intel.com> <1445507104-22563-1-git-send-email-jing.d.chen@intel.com> <1445507104-22563-4-git-send-email-jing.d.chen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 03/16] fm10k: Add a new func to initialize all parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Oct 2015 15:57:46 -0000 On Thu, 22 Oct 2015 17:44:51 +0800 "Chen Jing D(Mark)" wrote: > +static void > +fm10k_params_init(struct rte_eth_dev *dev) > +{ > + struct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private); > + struct fm10k_dev_info *info = FM10K_DEV_PRIVATE_TO_INFO(dev); > + /* Inialize bus info. Normally we would call fm10k_get_bus_info(), but > + * there is no way to get link status without reading BAR4. Until this > + * works, assume we have maximum bandwidth. > + * @todo - fix bus info Minor nit. I would prefer that DPDK follow current Linux kernel style which is to always have a blank line after declarations. This improves readability. I.e: static void fm10k_params_init(struct rte_eth_dev *dev) { struct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private); struct fm10k_dev_info *info = FM10K_DEV_PRIVATE_TO_INFO(dev); /* Inialize bus info. Normally we would call fm10k_get_bus_info(), but * there is no way to get link status without reading BAR4. Until this * works, assume we have maximum bandwidth. * @todo - fix bus info