From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) by dpdk.org (Postfix) with ESMTP id E806A5A1F for ; Fri, 23 Oct 2015 18:03:16 +0200 (CEST) Received: by pasz6 with SMTP id z6so121805356pas.2 for ; Fri, 23 Oct 2015 09:03:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=p9q8YD8p7Rwf1AL8xd7eMM9hTQV6vhD+iEVFndX2Emc=; b=hTc4o3U43GUBn+4E/72STAmMcpfTdhdjvZK5xSsyu7I3QY959c+9PetW0xKhkgmV4c zSvC1HYYYui2YHdC6rI3NtiwHWJ3diQSctlLvohJu8dijpv6FqswVAfHszTTJfONLf1f zE2FaaEBef0uuuW0WW3O8Ia0hCAoMelDgdPOee8FvqdWmhIfYuzput+KbdC7K46beNC3 YUr8EMOU4iA67xlqJJxNltyHDSNDEAw2M+UMR6BTN0/O3hc7mdo6pWDDE30QyUcCgbm9 5t9Q7VEu1UEf30rspjo6/DmSFIGDXA1Doz0tArkjIZ3XfdfuOFlm262s5VW02OFTgouM qjwQ== X-Gm-Message-State: ALoCoQnCLSgrzhneiqMmtUsIKVcHxpxSY5bxhpOFc7f8wWM3bUjK/wL7P9uEVsgCx6afcLQFn/XV X-Received: by 10.66.144.130 with SMTP id sm2mr2278927pab.105.1445616196076; Fri, 23 Oct 2015 09:03:16 -0700 (PDT) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id tn2sm19773207pac.0.2015.10.23.09.03.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Oct 2015 09:03:15 -0700 (PDT) Date: Fri, 23 Oct 2015 09:03:25 -0700 From: Stephen Hemminger To: Thomas Monjalon Message-ID: <20151023090325.3a83fa0c@xeon-e3> In-Reply-To: <1445615606-3885-2-git-send-email-thomas.monjalon@6wind.com> References: <1445615606-3885-1-git-send-email-thomas.monjalon@6wind.com> <1445615606-3885-2-git-send-email-thomas.monjalon@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/2] scripts: add checkpatch wrapper X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2015 16:03:17 -0000 On Fri, 23 Oct 2015 17:53:25 +0200 Thomas Monjalon wrote: > + > +# override default Linux options > +options="$options --max-line-length=$length" > +options="$options --show-types" > +options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\ > +VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,PREFER_KERNEL_TYPES,\ > +SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ > +NEW_TYPEDEFS,COMPLEX_MACRO,COMPARISON_TO_NULL" Please keep some of these: PARENTHESIS_ALIGNMENT LINUX_VERSION_CODE COMPLEX_MACRO All of these are indications of problems in code.