From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com
 [209.85.220.52]) by dpdk.org (Postfix) with ESMTP id 8BCDF5963
 for <dev@dpdk.org>; Fri, 23 Oct 2015 18:05:38 +0200 (CEST)
Received: by pabrc13 with SMTP id rc13so121674172pab.0
 for <dev@dpdk.org>; Fri, 23 Oct 2015 09:05:37 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=nOnaZYPQ1iQQc8fVwiHqLXSHDPCSv9Uwuluya/9BOyw=;
 b=Wzy0aDgO4+tX4sokxUijczjBRhnnidwyrrMSTCXXPGBXlKZ1Wt6sDj56sKHx4GfzKJ
 ZX4Z1AVIy38YlDfHpxFvcsz+fuad7g2hM7q5rYj3Mssi1XrC4rxRCORuYjXnNDGIaMPV
 QlPHvFrlXJUzo8isAl3qh3EhGeJk4EGJuKHhumtUnvJsC9IeNADESlUxoxtdb4L/AE35
 604XXCcqVlmL0zIbJB4xgssw4XHTLqjoUIxDfUqH9skg5l8oJaNs281oLN1Q27OHCMCz
 c2MEX5fSq2HtzksGKyb175TNFXmu6FOZUQF1WMCIwlHNgfNsinAyLfV5CRdAQriTIlGM
 mvZg==
X-Gm-Message-State: ALoCoQnoWLl5s86dqU65fSeuMYSQk4q/lkbh53Y/qGgc93/XbXqFcdN1xr7IeXOW7amcwQpc8Zj3
X-Received: by 10.68.94.69 with SMTP id da5mr5945354pbb.63.1445616337777;
 Fri, 23 Oct 2015 09:05:37 -0700 (PDT)
Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id g12sm19796664pat.36.2015.10.23.09.05.37
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 23 Oct 2015 09:05:37 -0700 (PDT)
Date: Fri, 23 Oct 2015 09:05:48 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Alejandro.Lucero" <alejandro.lucero@netronome.com>
Message-ID: <20151023090548.5fa59e0e@xeon-e3>
In-Reply-To: <1445596563-16818-2-git-send-email-alejandro.lucero@netronome.com>
References: <1445596563-16818-1-git-send-email-alejandro.lucero@netronome.com>
 <1445596563-16818-2-git-send-email-alejandro.lucero@netronome.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4] nfp: new poll mode driver for netronome
 nfp-6xxx card
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Oct 2015 16:05:39 -0000

On Fri, 23 Oct 2015 11:36:02 +0100
"Alejandro.Lucero" <alejandro.lucero@netronome.com> wrote:

> +static inline __u32
> +nfp_qcp_read(__u8 *q, enum nfp_qcp_ptr ptr)
> +{
> +	__u32 off;
> +	__u32 val;
> +

Please don't use Linux kernel typedefs (__u32) in DPDK code.
Instead use stdint types (uint32_t)