From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id 513E85A17 for ; Fri, 23 Oct 2015 18:56:02 +0200 (CEST) Received: by pasz6 with SMTP id z6so122874372pas.2 for ; Fri, 23 Oct 2015 09:56:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=8v+8uZV6eWwZZmQRGR/7teO73j36govPnkvvVx+UT3k=; b=XI50l0zp9cGOVBwXWwZF9jvUcSaHYWE94KZWTUunqcGX9bzPpVeMjdTLgyacSwfy9C PjLMsvH9ZSwWDvB39zIVKsqAhi3xfmXT863uCYvp5FZCGLN/NC8X2HISiY1eE9pvIGw8 ytukHLdOgdhmz1J8jKVBCddzarVHVtPjY7kiMckT95TXU1PjIz8KcGFinOq1bPPeBUwr 9Iticgzd1lpK60OE2tF5rsgWLM7BfAfrfSohuxkKIg9zFOPHhbz/NwDRlEti+FxCPlU0 yjQUGZklkVkgJwjV+HdTdZYnZLc/A1yY0CiBNRUHlHl9naGW4j5yaNqs4CaWD/zPwBhy 38Iw== X-Gm-Message-State: ALoCoQnKVSVJdK53OHTRo1ZWC1YNuw77YRiuC4cn9VA+m2xypKbc0NWNz43oQl8LReWoV2jxNISL X-Received: by 10.66.254.130 with SMTP id ai2mr5868104pad.89.1445619361561; Fri, 23 Oct 2015 09:56:01 -0700 (PDT) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id qy7sm19956959pab.37.2015.10.23.09.56.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Oct 2015 09:56:01 -0700 (PDT) Date: Fri, 23 Oct 2015 09:56:11 -0700 From: Stephen Hemminger To: Thomas Monjalon Message-ID: <20151023095611.46a5d69f@xeon-e3> In-Reply-To: <4288301.N0F7Gaqfh8@xps13> References: <1445615606-3885-1-git-send-email-thomas.monjalon@6wind.com> <1445615606-3885-2-git-send-email-thomas.monjalon@6wind.com> <20151023090325.3a83fa0c@xeon-e3> <4288301.N0F7Gaqfh8@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/2] scripts: add checkpatch wrapper X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2015 16:56:02 -0000 On Fri, 23 Oct 2015 18:34:23 +0200 Thomas Monjalon wrote: > > Please keep some of these: > > PARENTHESIS_ALIGNMENT > > It is not written in the DPDK coding rules that > "Alignment should match open parenthesis" I think code looks nicer if this rule is followed. Ditto for the LINE_SPACING rule.