From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B7AE85A89 for ; Fri, 23 Oct 2015 16:39:05 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 23 Oct 2015 07:38:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,186,1444719600"; d="scan'208";a="833898685" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.66]) by fmsmga002.fm.intel.com with SMTP; 23 Oct 2015 07:38:56 -0700 Received: by (sSMTP sendmail emulation); Fri, 23 Oct 2015 15:38:54 +0025 Date: Fri, 23 Oct 2015 15:38:54 +0100 From: Bruce Richardson To: Michal Jastrzebski Message-ID: <20151023143854.GB26964@bricha3-MOBL3> References: <1445608311-8092-1-git-send-email-michalx.k.jastrzebski@intel.com> <1445608311-8092-2-git-send-email-michalx.k.jastrzebski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445608311-8092-2-git-send-email-michalx.k.jastrzebski@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v1 1/3] lpm: increase number of next hops for lpm (ipv4) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2015 14:39:06 -0000 On Fri, Oct 23, 2015 at 03:51:49PM +0200, Michal Jastrzebski wrote: > From: Michal Kobylinski > > Main implementation - changes to lpm library regarding new data types. > Additionally this patch implements changes required by test application. > ABI versioning requirements are met only for lpm library, > for table library it will be sent in v2 of this patch-set. > > Signed-off-by: Michal Kobylinski > --- > app/test/test_func_reentrancy.c | 4 +- > app/test/test_lpm.c | 227 +++++----- > lib/librte_lpm/rte_lpm.c | 887 ++++++++++++++++++++++++++++++++++++- > lib/librte_lpm/rte_lpm.h | 295 +++++++++++- > lib/librte_lpm/rte_lpm_version.map | 59 ++- > lib/librte_table/rte_table_lpm.c | 10 +- > 6 files changed, 1322 insertions(+), 160 deletions(-) > > diff --git a/app/test/test_func_reentrancy.c b/app/test/test_func_reentrancy.c > index dbecc52..331ab29 100644 > --- a/app/test/test_func_reentrancy.c > +++ b/app/test/test_func_reentrancy.c > @@ -343,7 +343,7 @@ static void > lpm_clean(unsigned lcore_id) > { > char lpm_name[MAX_STRING_SIZE]; > - struct rte_lpm *lpm; > + struct rte_lpm_extend *lpm; I thought this patchset was just to increase the size of the lpm entries, not to create a whole new entry type? The structure names etc. should all stay the same, and let the ABI versionning take care of handling code using the older structures. /Bruce