From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 8E3E05A65
 for <dev@dpdk.org>; Tue, 27 Oct 2015 11:10:27 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga102.jf.intel.com with ESMTP; 27 Oct 2015 03:10:26 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,204,1444719600"; d="scan'208";a="672580859"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.66])
 by orsmga003.jf.intel.com with SMTP; 27 Oct 2015 03:10:24 -0700
Received: by  (sSMTP sendmail emulation); Tue, 27 Oct 2015 10:10:24 +0025
Date: Tue, 27 Oct 2015 10:10:23 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Remy Horton <remy.horton@intel.com>
Message-ID: <20151027101023.GA9176@bricha3-MOBL3>
References: <1443603881-4700-1-git-send-email-remy.horton@intel.com>
 <1443603881-4700-3-git-send-email-remy.horton@intel.com>
 <1A27633A6DA49C4A92FCD5D4312DBF536A5D9327@IRSMSX109.ger.corp.intel.com>
 <562F3A69.1040306@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <562F3A69.1040306@intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 2/3] l2fwd: keep alive sample application
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Oct 2015 10:10:28 -0000

On Tue, Oct 27, 2015 at 08:48:41AM +0000, Remy Horton wrote:
> 
> 
> On 23/10/2015 15:23, Tahhan, Maryam wrote:
> 
> >>  # binary name
> >>-APP = l2fwd
> >>+APP = l2fwd-keepalive
> >Hi Remy,
> >Looks great overall, just a couple of comments
> >For backward compatibility the rename could be a nightmare? What do you think?
> 
> True. Undecided whether to change the Makefile(s) so that both keepalive and
> non-keepalive l2fwd are built, or to simply clone all of l2fwd..
> 

My opinion is that l2fwd should be kept as simple as possible, so I'd suggest
cloning to provide a separate keepalive example.

/Bruce