From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 66B41374E
 for <dev@dpdk.org>; Tue, 27 Oct 2015 11:17:27 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga102.fm.intel.com with ESMTP; 27 Oct 2015 03:17:26 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,204,1444719600"; d="scan'208";a="672584278"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.66])
 by orsmga003.jf.intel.com with SMTP; 27 Oct 2015 03:17:24 -0700
Received: by  (sSMTP sendmail emulation); Tue, 27 Oct 2015 10:17:23 +0025
Date: Tue, 27 Oct 2015 10:17:23 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Message-ID: <20151027101723.GB9176@bricha3-MOBL3>
References: <1443537953-23917-1-git-send-email-huawei.xie@intel.com>
 <1445787304-18267-1-git-send-email-huawei.xie@intel.com>
 <ED26CBA2FAD1BF48A8719AEF02201E36607C9A@SHSMSX103.ccr.corp.intel.com>
 <20151027021501.GA3115@yliu-dev.sh.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151027021501.GA3115@yliu-dev.sh.intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 0/7] virtio ring layout optimization and
 simple rx/tx processing
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Oct 2015 10:17:27 -0000

On Tue, Oct 27, 2015 at 10:15:01AM +0800, Yuanhan Liu wrote:
> On Tue, Oct 27, 2015 at 01:44:09AM +0000, Tan, Jianfeng wrote:
> > 
> > 
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Huawei Xie
> > > Sent: Sunday, October 25, 2015 11:35 PM
> > > To: dev@dpdk.org
> > > Subject: [dpdk-dev] [PATCH v5 0/7] virtio ring layout optimization and simple
> > > rx/tx processing
> > > 
> > > Changes in v5:
> > > - Call __rte_pktmbuf_prefree_seg to check refcnt when free mbufs
> > > 
> > > Changes in v4:
> > > - Fix the error in virtio tx ring layout ascii chart in the commit message
> > > - Move virtio_xmit_cleanup ahead to free descriptors earlier
> > > - Test merge-able feature when select simple rx/tx functions
> 
> [...]
> 
> > 
> > Acked-by Jianfeng Tan <jianfeng.tan@intel.com>
> 
> Jianfeng,
> 
> I often see a reply like this, just dropping an ACK at the end of
> long email, and no more, which takes me (as well as others) some
> time to scroll it many times to the bottom till see that.
> 
> TBH, it's always a bit frustrating that, after the scroll effort,
> I just see such a reply that could have been put on the top of
> the email so that I can see it with a glimpse only.
> 
> So, top reply would be good for this case, or you could reply like
> what I did, removing other context to make your reply fit in one
> screen.
> 
> 	--yliu

+1 

When ack'ing patches, please place the ack on the line underneath the signoff
and delete the rest of the email below, as it's unneeded.

/Bruce