DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Polehn, Mike A" <mike.a.polehn@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [Patch] Eth Driver: Optimization for improved NIC processing rates
Date: Wed, 28 Oct 2015 10:44:37 +0000	[thread overview]
Message-ID: <20151028104437.GA8052@bricha3-MOBL3> (raw)
In-Reply-To: <745DB4B8861F8E4B9849C970520ABBF14974C1DF@ORSMSX102.amr.corp.intel.com>

On Tue, Oct 27, 2015 at 08:56:31PM +0000, Polehn, Mike A wrote:
> Prefetch of interface access variables while calling into driver RX and TX subroutines.
> 
> For converging zero loss packet task tests, a small drop in latency for zero loss measurements 
> and small drop in lost packet counts for the lossy measurement points was observed, 
> indicating some savings of execution clock cycles.
> 
Hi Mike,

the commit log message above seems a bit awkward to read. If I understand it
correctly, would the below suggestion be a shorter, clearer equivalent?

	Prefetch RX and TX queue variables in ethdev before driver function call

	This has been measured to produce higher throughput and reduced latency
	in RFC 2544 throughput tests.

Or perhaps you could suggest yourself some similar wording. It would also be
good to clarify with what applications the improvements were seen - was it using
testpmd or l3fwd or something else?

Regards,
/Bruce

  reply	other threads:[~2015-10-28 10:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 20:56 Polehn, Mike A
2015-10-28 10:44 ` Bruce Richardson [this message]
2015-10-28 21:27   ` Polehn, Mike A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151028104437.GA8052@bricha3-MOBL3 \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=mike.a.polehn@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).