From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wes1-so2.wedos.net (wes1-so2.wedos.net [46.28.106.16]) by dpdk.org (Postfix) with ESMTP id 2A456231C for ; Wed, 28 Oct 2015 18:38:50 +0100 (CET) Received: from jvn (dynamic-109-81-211-164.ipv4.broadband.iol.cz [109.81.211.164]) by wes1-so2.wedos.net (Postfix) with ESMTPSA id 3nmHFP5xjhzBjN; Wed, 28 Oct 2015 18:38:49 +0100 (CET) Date: Wed, 28 Oct 2015 18:38:37 +0100 From: Jan Viktorin To: David Marchand Message-ID: <20151028183837.5612029d@jvn> In-Reply-To: References: <1445877458-31052-1-git-send-email-viktorin@rehivetech.com> <1445973229-22058-1-git-send-email-viktorin@rehivetech.com> Organization: RehiveTech X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 00/17] Support ARMv7 architecture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2015 17:38:50 -0000 On Wed, 28 Oct 2015 15:54:47 +0100 David Marchand wrote: > Hello Jan, > > On Tue, Oct 27, 2015 at 8:13 PM, Jan Viktorin > wrote: > > > Hello DPDK community, > > > > this is the third attempt to post support for ARMv7 into the DPDK. > > There are changes related to the LPM and ACL libraries only: > > > > * included rte_vect.h, however, it is more a placeholder > > * rte_lpm.h was simplified due to the previous point > > * ACL now compiles as we detect whether the compiler > > supports SSE 4.1 > > > > This patchset looks good to me (with the minor comments I sent). > And armv8 support should fit quite well in this. > > A last few things : > - checkpatch is not happy with some patches, can you have a look at this ? I will check this. > - can you update the 2.2 release notes as part of this patchset to announce > armv7 support ? Yes, but where? > - I am not really sure the acl et lpm fixes really belong to this patchset > as a more larger cleanup is necessary to have all libraries compile fine on > non-x86 So, you mean to omit those and disable them all? The LPM and ACL fixes will be then included in 2.3? > - since you introduce a new architecture, do you intend to run daily build > checks and send reports to the test-report mailing list ? I think, this is possible, if I automate it somehow. Do you mean to test every individual patch? I have no tools for this (some ideas?). If its just about git pull && test_script.sh, then it is quite OK. I'd appreciate some help, ideas, advices, experiences in this area... > > > Thanks. > Jan -- Jan Viktorin E-mail: Viktorin@RehiveTech.com System Architect Web: www.RehiveTech.com RehiveTech Brno, Czech Republic