From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by dpdk.org (Postfix) with ESMTP id 73EF38D9D for ; Wed, 28 Oct 2015 22:32:24 +0100 (CET) Received: by padhy1 with SMTP id hy1so12033617pad.0 for ; Wed, 28 Oct 2015 14:32:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber_org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=+btRULkoixavOfGOpzpMXRjzEAckEJbBsLjjWUW38Uc=; b=LzO/WPRdfFvueK/uh8vXt69iamdsWBVxFG9k5qDIF4MYNR4wuBUBHnGHULHLTAGHcJ pv3uFf9HgucVRS1YZtZJgIUR/aDwrajDs7dz7DJaxFu1Tp0bFL6MDIeAE39GsiNJpO97 ozK8b1CXbi8QT4YJU5CYrNMJoUUAPiY5mkBqYI13QzF3g4MH39FsNQYCPXfjVhlNyXN6 ZIphSnlZ9x0SRhYGBcNzuVlrpCUdyMz/SaH4bF3hrL6yoaFPbULgtKkOf7JPhBTg0CJh jnH6CA8rGK9Jr160Qn5nS4sLChFx3XXi0xu/ODoE5uZa82mJ4G9IjJk/EP6/RvZ6j02z u5Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=+btRULkoixavOfGOpzpMXRjzEAckEJbBsLjjWUW38Uc=; b=hPiY26+l3XHjszrk8WUZkm+rW/cNgHBdG9/dr+g/4mYT6Upb99Zemf4XjTr5IdVoJy +Tir6+wZK3zl1p67GfW5vZqR3pRv+fEzGI03GJ1cd75t4szoHNRCin7omRGn0BH2zv4u hIl5upxNM1EGeOfJuGi+WQyBu9gyxY+XI2s99isrz/LjaVK7KVZjpwFJaQjFvWGJCp40 7vBGHfke9Py0EYiICABNV7r2IYMtBAGS4W+ndSJDtBva6FQt8avgR5mVvCMRrTK6kk0X 93M17lqOrQCXW7jEQIUYE6zBEv1Lep4H3CLMGg70F+sNyZmvgTYdhxj1oNS6szg+X41g Vmdg== X-Gm-Message-State: ALoCoQkFBYCCNNwUB9syHIVQBBEW0/jSHx0fvueHkbQ6t6GDT1GDNKPtMov82CKO7thVTho6gzkU X-Received: by 10.68.168.164 with SMTP id zx4mr36033768pbb.75.1446067943537; Wed, 28 Oct 2015 14:32:23 -0700 (PDT) Received: from samsung9 ([58.123.138.205]) by smtp.gmail.com with ESMTPSA id kp4sm47182590pbc.34.2015.10.28.14.32.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Oct 2015 14:32:23 -0700 (PDT) Date: Thu, 29 Oct 2015 06:32:16 +0900 From: Stephen Hemminger To: Tom Crugnale Message-ID: <20151029063216.4675da65@samsung9> In-Reply-To: <9689034CEF26614CAB4B447EEAAF98E918241AD3@wtl-exchp-1.sandvine.com> References: <1443606022-13581-2-git-send-email-harry.van.haaren@intel.com> <1445528914-27636-1-git-send-email-harry.van.haaren@intel.com> <9689034CEF26614CAB4B447EEAAF98E918241AD3@wtl-exchp-1.sandvine.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 00/11] Port XStats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2015 21:32:24 -0000 On Wed, 28 Oct 2015 17:35:09 +0000 Tom Crugnale wrote: > Hi Harry, > > We are planning on using the xstats API for periodic stats collection through a polling thread. This would be done in a generic NIC agnostic manner, which would require that the xstats identifiers have consistent naming amongst all of the NIC types. It would likely be polled several times per second and would only gather a subset of all available xstats types. > > I have reviewed your patches and am interested in providing some API enhancements and bugfixes. Are you willing to provide feedback on such changes? > > Thank you, > Tom The whole point of xstats is to allow device specific statistics. Consistent use of names is good from a user interface point of view, but probably not a hard requirement.